Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix morph from text node to comment node #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix morph from text node to comment node #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function walk (newNode, oldNode) {
return null
} else if (newNode.isSameNode && newNode.isSameNode(oldNode)) {
return oldNode
} else if (newNode.tagName !== oldNode.tagName || getComponentId(newNode) !== getComponentId(oldNode)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be nice having a related unit test

Copy link
Author

@bennlich bennlich Nov 2, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble reproducing this in the test environment. Could it have something to do with the browser DOM?

In the browser, this successfully fails:

<div id="test">
  <!-- 1 -->
  <!-- 2 -->
</div>

<script type="module">

  import morph from './nanomorph.es6.js'
  import html from './nanohtml.es6.js'

  let parent = document.querySelector('#test')

  document.addEventListener('click', () => {
    morph(parent, html`
      <div id="test">
        <div>Hello</div>
        <!-- 1 -->
        <!-- 2 -->
      </div>
    `)
  })

</script>

but this test does not fail:

t.test('comments', function (t) {
    var a = html`<div>
  <!-- 1 -->
  <!-- 2 -->
</div>`
    var b = html`<div>
  <div>Hello</div>
  <!-- 1 -->
  <!-- 2 -->
</div>`
    var expected = b.outerHTML
    var c = nanomorph(a, b)
    t.equal(c.outerHTML, expected)
    t.end()
})

} else if (newNode.nodeName !== oldNode.nodeName || getComponentId(newNode) !== getComponentId(oldNode)) {
return newNode
} else {
morph(newNode, oldNode)
Expand Down