Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword bear comment #2892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IronPenguin4179
Copy link

Adds comment clarifying use of language setting in KeywordBear.

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57, file tests/general/KeywordBearTest.py, line 27.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp631cb2jc/tests/general/KeywordBearTest.py
+++ b/tmp/tmp631cb2jc/tests/general/KeywordBearTest.py
@@ -24,7 +24,8 @@
                    'test line warNING'),
     settings={'keywords': 'todo, warning',
               'language': 'c'})
-    #Language setting is used to generate the diff correctly and doesn't influence where the keyword may appear.
+# Language setting is used to generate the diff correctly and doesn't influence where the keyword may appear.
+
 
 class KeywordBearDiffTest(unittest.TestCase):
 

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57, file tests/general/KeywordBearTest.py, line 27.

E116 unexpected indentation (comment)

Origin: PycodestyleBear (E116), Section: all.autopep8.

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57, file tests/general/KeywordBearTest.py, line 27.

E265 block comment should start with '# '

Origin: PycodestyleBear (E265), Section: all.autopep8.

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57, file tests/general/KeywordBearTest.py, line 27.

E501 line too long (112 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57, file tests/general/KeywordBearTest.py, line 29.

E302 expected 2 blank lines, found 1

Origin: PycodestyleBear (E302), Section: all.autopep8.

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57, file tests/general/KeywordBearTest.py, line 27.

Line is longer than allowed. (112 > 80)

Origin: LineLengthBear, Section: all.linelength.

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57.

Shortlog of the HEAD commit contains 108 character(s). This is 58 character(s) longer than the limit (108 > 50).

Origin: GitCommitBear, Section: all.commit.

@gitmate-bot
Copy link
Collaborator

Comment on 1b88d57.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+: [A-Z0-9].*)

Origin: GitCommitBear, Section: all.commit.

@gitmate-bot
Copy link
Collaborator

Comment on 8bc0fb3.

Shortlog of HEAD commit contains a period at end.

Origin: GitCommitBear, Section: all.commit.

Adds comment clarifying use of language setting.

Fixes coala#2798
Copy link
Member

@AkshJain99 AkshJain99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinwalker4179 just check commit message it does not follow coala guidelines
and also test is failing checkout that once again if you are still working on this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants