bears/general: Add RegexLintBear #2934
Conversation
bkhanale
force-pushed
the
regexlintbear
branch
2 times, most recently
from
b03ce82
to
89a8ff1
Compare
| import re | ||
|
|
||
| from queue import Queue | ||
| from sarge import run, Capture |
There was a problem hiding this comment.
sarge is coala dependency?
Afaik, sarge comes from package_manager, if you are using it directly here, you'll need to add it to requirements.txt.
Maybe you can confirm this from @jayvdb
There was a problem hiding this comment.
I think I'm not very sure about this since we might just create a conflict if the versions mismatch later on.
There was a problem hiding this comment.
Add the PipRequirement , but we have some magic piece of code somewhere in .ci/generate_* which excludes dependencies which are also provided by our own downstream. e.g. this is used for requests which is provided by coala
There was a problem hiding this comment.
@jayvdb About this, I wasn't sure about the version to include since on package_manager we install from hg+https://bitbucket.org/jayvdb/sarge@win-reg-lookup#egg=sarge. Will it break stuff?
|
Restarted few jobs, there was a timeout. |
|
@sangamcse @kriti21 You guys can also have a look. |
bkhanale
force-pushed
the
regexlintbear
branch
from
c8eceda
to
a91eeeb
Compare
| import re | ||
|
|
||
| from queue import Queue | ||
| from sarge import run, Capture |
There was a problem hiding this comment.
Add the PipRequirement , but we have some magic piece of code somewhere in .ci/generate_* which excludes dependencies which are also provided by our own downstream. e.g. this is used for requests which is provided by coala
bkhanale
force-pushed
the
regexlintbear
branch
2 times, most recently
from
d6e6daa
to
49cdf5a
Compare
bkhanale
force-pushed
the
regexlintbear
branch
from
49cdf5a
to
029df27
Compare
Closes #1532
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!