Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed faq link #2979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed faq link #2979

wants to merge 1 commit into from

Conversation

ParthS28
Copy link

@ParthS28 ParthS28 commented Sep 30, 2020

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@ParthS28
Copy link
Author

README.rst: Fixed the FAQ link

Updates the FAQ link.

Closes #2821

Copy link
Contributor

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes LGTM. However, can you update your commit message (not the pull request message) to follow the commit guidelines? Let me know if you need help with this.

virtualenv <https://github.com/coala/coala/wiki/FAQ#installation-is-failing-help>`__
virtualenv <http://docs.coala.io/en/latest/Help/FAQ.html>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather use http://docs.coala.io/en/latest/Help/FAQ.html#installation-is-failing-help instead. Simply pointing to FAQ doesn't help, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants