Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ.rst:Replace a FAQ #566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sarthakchakerverty
Copy link
Contributor

@sarthakchakerverty sarthakchakerverty commented Jul 26, 2018

Replace a FAQ about pull requests with how to contribute to coala.

closes: #552

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Copy link
Contributor

@chhabrabhishek chhabrabhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question must be in heading format.
And you can work on your code syntax correction of the code for RST format.
To check syntax please refer "http://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html".
Also, improve your commit message by correcting the typo from reaplace->replace.

@sarthakchakerverty
Copy link
Contributor Author

@chhabrabhishek made the requested changes.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three commits at https://github.com/coala/documentation/pull/566/commits

Please squash your commits

@sarthakchakerverty
Copy link
Contributor Author

@chhabrabhishek @jayvdb squashed the commits.Please review!

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better.

Now amend your commit message to be exactly as described at https://coala.io/commit .

It is checked by a bot. Your patch will keep being rejected until you follow it precisely.

@sarthakchakerverty
Copy link
Contributor Author

@jayvdb Commit message is now editted.

@sarthakchakerverty sarthakchakerverty changed the title FAQ.rst:Reaplace a FAQ FAQ.rst:Replace a FAQ Aug 1, 2018
This commit replaces FAQ: 'What are these passing/failing tests on my PRs?' --> 'Need help contributing to coala?'

closes: coala#552
@jayvdb
Copy link
Member

jayvdb commented Aug 1, 2018

At least two things wrong with your commit message.

Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message as per the commit guidelines.
Send a fix at the earliest.

Copy link
Member

@ManthanKeim ManthanKeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing space in your commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Replace FAQ item about pull requests
6 participants