Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo.html: Make header icon responsive #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anmolbansal1
Copy link
Contributor

@Anmolbansal1 Anmolbansal1 commented Jan 15, 2019

Makes the header icon of docs.coala.io more responsive.

Closes coala/landing-frontend#299
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!
  • I read the commit guidelines and I've followed
    them.

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@Anmolbansal1
Copy link
Contributor Author

@shashank-b please review

Copy link
Member

@Dhiraj240 Dhiraj240 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow commit guidelines and then amend your commit message.

@Anmolbansal1
Copy link
Contributor Author

@Dhiraj240 please check now

Copy link
Member

@Dhiraj240 Dhiraj240 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please read the link properly.You haven't followed it, add issue reference.

<div class="coala-logo-doc-low">
<img width="187.5px" height="187.5px" src="_static/images/coala_logo.svg">
</div>
</body>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add EOL at EOF

logo.html: Display header according to screen width

Now bear-header is rendered according to screen-width.

Closes coala/landing-frontend#299
@Anmolbansal1
Copy link
Contributor Author

@jayvdb please check now

@jayvdb jayvdb requested a review from sangamcse February 3, 2019 08:40
@jayvdb
Copy link
Member

jayvdb commented Feb 3, 2019

@sangamcse can you take a look at this.

We should be probably doing this in the artwork repo, and sync'ing here, etc?

@sangamcse
Copy link
Member

.. image:: _static/images/coala-header.png
:scale: 50
:align: center
.. raw:: html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if we can add SVG here or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

docs.coala.io: Header's aspect ratio not consistent (in mobile browsers)
5 participants