Add GSoC report link for completed tasks #714

KVGarg · 2019-02-17T16:37:11Z

This commit adds the corresponding GSoC report
link for completed tasks.

Closes #703

Checklist

I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

TravisBuddy · 2019-02-17T18:02:47Z

Travis tests have failed

Hey @KVGarg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][18:02:36] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/partials/tabs/projects.html
|    |++++| /app/partials/tabs/projects.html
|  61|  61|           <div class="small-heading uppercase">Initiatives</div> <span class="chip" ng-repeat="initiative in currentProject.initiatives">{{ initiative }}</span>
|  62|  62|           <br> </div>
|  63|  63|         <div ng-show="currentProject.report.length>0">
|  64|    |-          <div class="small-heading uppercase">GSoC</div> 
|    |  64|+          <div class="small-heading uppercase">GSoC</div>
|  65|  65|           <span class="chip gsoc-report" ng-click="redirectToReport()">Report</span>
|  66|  66|         </div>
|  67|  67|         <div ng-show="currentProject.collaborating_projects.length>0">
[INFO][18:02:38] Applied 'ShowPatchAction' on 'partials/tabs/projects.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][18:02:38] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][18:02:38] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][18:02:38] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][18:02:38] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][18:02:38] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][18:02:38] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][18:02:39] HTMLLintBear: This result has no patch attached.

partials/tabs/projects.html
|  64| ··········<div·class="small-heading·uppercase">GSoC</div>·
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...
nothing changed, not updating cache


Done. Your build exited with 1.

TravisBuddy Request Identifier: 399b7a50-32de-11e9-909a-37b9af0e35d8

frextrite

Report section is not showing up in the project details popup. Have a look at it.

KVGarg · 2019-02-18T09:24:51Z

@frextrite not all completed projects are having report section on the LHS. Only few of completed projects, around 22 completed projects are having that section.
You can find it below initiatives, having a title of GSoC for completed projects.

frextrite · 2019-02-18T10:32:36Z

My bad. Can see them now. I was looking for the report link in the uncompleted projects.

frextrite · 2019-02-18T10:34:45Z

Sidenote: You may want to check everything in the checklist

li-boxuan

Looks good 👍

_projects/antlr-v4.md

resources/js/app.js

TravisBuddy · 2019-02-24T11:17:06Z

Travis tests have failed

Hey @KVGarg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][11:16:54] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][11:16:57] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][11:16:57] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][11:16:57] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][11:16:57] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][11:16:57] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][11:16:57] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/partials/tabs/projects.html
|    |++++| /app/partials/tabs/projects.html
|  61|  61|           <div class="small-heading uppercase">Initiatives</div> <span class="chip" ng-repeat="initiative in currentProject.initiatives">{{ initiative }}</span>
|  62|  62|           <br> </div>
|  63|  63|         <div ng-show="currentProject.report.length>0">
|  64|    |-          <div class="small-heading uppercase">GSoC</div> 
|    |  64|+          <div class="small-heading uppercase">GSoC</div>
|  65|  65|           <span class="chip gsoc-report" ng-click="redirectToReport()">Report</span>
|  66|  66|         </div>
|  67|  67|         <div ng-show="currentProject.collaborating_projects.length>0">
[INFO][11:16:57] Applied 'ShowPatchAction' on 'partials/tabs/projects.html' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][11:16:57] HTMLLintBear: This result has no patch attached.

partials/tabs/projects.html
|  64| ··········<div·class="small-heading·uppercase">GSoC</div>·
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Executing section yml...
Executing section cli...

TravisBuddy Request Identifier: b5f860d0-3825-11e9-b76d-d9638afbe879

TravisBuddy · 2019-08-22T14:52:44Z

Travis tests have failed

Hey @KVGarg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7db4fd10-c4ec-11e9-8712-75d78f9b457f

jayvdb · 2019-08-24T18:19:20Z

These links should be derived from the other metadata. DRY.
If necessary, the links can be built in jekyll before being served for the frontend to use.

KVGarg · 2019-08-24T18:23:41Z

So, we should get work report based on project tile because it is the only common thing that can be there between a project and a work report, right?

KVGarg · 2019-08-25T13:41:07Z

The current preview is displaying reports option on project popup, only if the project name is same as that in report 😞

jayvdb

If a GSoC report was found, the list of initiatives is no longer valid if it contained items other than GSoC, and doesnt need to be shown as it is wasting space at the top of the UI.

Partial matching isnt acceptable. Old data needs to be grand-fathered in.

Please add an extra commit, or add a PR based on top of this one, which matches the reports for all GSoC projects, and removes the old initiatives. You can change titles , etc, or add extra attributes to be able to join report to project. But old URLs must not be broken, so any URL change needs a redirect added, either using netlify redirects or redirects built using jekyll or redirects built in ng.

This commit adds the corresponding GSoC report link for completed tasks. Closes coala#703

KVGarg · 2019-08-26T19:05:13Z

For these two projects I wasn't able to find reports:

Documentation Extraction and Parsing
Extend Linter Integration

else i found all reports and added a new attribute to projects *.md files named improved_title which consists of the value of project name corresponding to the report!
If any GSoCer changes the default project name, the user will have to add this new attr to project having the new name of the project from there report!

The commit adds the new title for all those completed projects who got a new and a suitable title during the program. As the student starts working on project, user get to know "what will the be the most suitable title for the project?" and uses that in the work report too. So, add all such titles from reports to there corresponding projects. Also, this change will allow us to display the student work report itself on the project popup.

gitmate-bot added process/pending review size/S difficulty/low enhancement labels Feb 17, 2019

gitmate-bot assigned KVGarg Feb 17, 2019

This comment has been minimized.

Sign in to view

KVGarg force-pushed the link-to-report-for-completed-tasks branch 2 times, most recently from c278130 to f12dc75 Compare February 17, 2019 17:59

This comment has been minimized.

Sign in to view

frextrite suggested changes Feb 18, 2019

View reviewed changes

frextrite approved these changes Feb 18, 2019

View reviewed changes

li-boxuan reviewed Feb 22, 2019

View reviewed changes

_projects/antlr-v4.md Outdated Show resolved Hide resolved

resources/js/app.js Outdated Show resolved Hide resolved

li-boxuan added process/wip and removed process/pending review labels Feb 22, 2019

KVGarg force-pushed the link-to-report-for-completed-tasks branch from f12dc75 to 48929e5 Compare February 24, 2019 11:14

gitmate-bot added process/pending review and removed process/wip labels Feb 24, 2019

KVGarg force-pushed the link-to-report-for-completed-tasks branch from 48929e5 to 6ac493a Compare August 22, 2019 14:38

KVGarg force-pushed the link-to-report-for-completed-tasks branch from 6ac493a to 6b94da2 Compare August 22, 2019 15:03

jayvdb added process/wip and removed process/pending review labels Aug 24, 2019

KVGarg force-pushed the link-to-report-for-completed-tasks branch from 6b94da2 to 7067dc8 Compare August 25, 2019 13:18

KVGarg force-pushed the link-to-report-for-completed-tasks branch from 7067dc8 to 05f8057 Compare August 25, 2019 13:25

KVGarg force-pushed the link-to-report-for-completed-tasks branch from 05f8057 to 74b70b4 Compare August 25, 2019 14:20

jayvdb requested changes Aug 25, 2019

View reviewed changes

KVGarg force-pushed the link-to-report-for-completed-tasks branch 2 times, most recently from 0c0c445 to 53e114f Compare August 26, 2019 11:27

KVGarg changed the title ~~Add GSoC report link for completed tasks~~ Add GSoC report link for completed tasks [WIP] Aug 26, 2019

Add GSoC report link for completed tasks

e39fa05

This commit adds the corresponding GSoC report link for completed tasks. Closes coala#703

KVGarg force-pushed the link-to-report-for-completed-tasks branch from 53e114f to f3fa76c Compare August 26, 2019 19:20

KVGarg changed the title ~~Add GSoC report link for completed tasks [WIP]~~ Add GSoC report link for completed tasks Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GSoC report link for completed tasks #714

Add GSoC report link for completed tasks #714

KVGarg commented Feb 17, 2019 •

edited

This comment has been minimized.

This comment has been minimized.

TravisBuddy commented Feb 17, 2019

frextrite left a comment

KVGarg commented Feb 18, 2019 •

edited

frextrite commented Feb 18, 2019

frextrite commented Feb 18, 2019

li-boxuan left a comment

TravisBuddy commented Feb 24, 2019

TravisBuddy commented Aug 22, 2019

jayvdb commented Aug 24, 2019

KVGarg commented Aug 24, 2019

KVGarg commented Aug 25, 2019

jayvdb left a comment

KVGarg commented Aug 26, 2019

Add GSoC report link for completed tasks #714

Are you sure you want to change the base?

Add GSoC report link for completed tasks #714

Conversation

KVGarg commented Feb 17, 2019 • edited

Checklist

This comment has been minimized.

This comment has been minimized.

TravisBuddy commented Feb 17, 2019

Travis tests have failed

Ruby: 2.5.1

TravisBuddy Request Identifier: 399b7a50-32de-11e9-909a-37b9af0e35d8

frextrite left a comment

Choose a reason for hiding this comment

KVGarg commented Feb 18, 2019 • edited

frextrite commented Feb 18, 2019

frextrite commented Feb 18, 2019

li-boxuan left a comment

Choose a reason for hiding this comment

TravisBuddy commented Feb 24, 2019

Travis tests have failed

Ruby: 2.5.1

TravisBuddy Request Identifier: b5f860d0-3825-11e9-b76d-d9638afbe879

TravisBuddy commented Aug 22, 2019

Travis tests have failed

TravisBuddy Request Identifier: 7db4fd10-c4ec-11e9-8712-75d78f9b457f

jayvdb commented Aug 24, 2019

KVGarg commented Aug 24, 2019

KVGarg commented Aug 25, 2019

jayvdb left a comment

Choose a reason for hiding this comment

KVGarg commented Aug 26, 2019

KVGarg commented Feb 17, 2019 •

edited

KVGarg commented Feb 18, 2019 •

edited