Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: roachtest/cdc: ensure hydra endpoint is up #124370

Merged

Conversation

rharding6373
Copy link
Collaborator

@rharding6373 rharding6373 commented May 17, 2024

Backport 1/1 commits from #123345.

/cc @cockroachdb/release


When we start hydra to enable oauth during roachtest testing, the admin endpoint may not have started before the create oauth client command is called, resulting in a test failure. This PR puts the create command in a retry loop with a timeout so that the command has a chance to succeed.

Fixes: #122456
Epic: None

Release note: None

Release Justification: Test-only change to deflake CDC roachtests by waiting until hydra endpoint is up to start oauth.

When we start hydra to enable oauth during roachtest testing, the admin
endpoint may not have started before the create oauth client command is
called, resulting in a test failure. This PR puts the create command in
a retry loop with a timeout so that the command has a chance to succeed.

Fixes: cockroachdb#122456
Epic: None

Release note: None
@rharding6373 rharding6373 requested a review from a team as a code owner May 17, 2024 21:42
@rharding6373 rharding6373 requested review from nameisbhaskar and removed request for a team May 17, 2024 21:42
Copy link

blathers-crl bot commented May 17, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 17, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting!

@rharding6373 rharding6373 merged commit 2b4a722 into cockroachdb:release-23.2 May 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants