chore: Remove/replace useCoverageWithFilters #2873
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 880 878 -2
Lines 13037 13026 -11
Branches 3491 3470 -21
==========================================
- Hits 12839 12828 -11
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2873 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 880 878 -2
Lines 13037 13026 -11
Branches 3473 3425 -48
==========================================
- Hits 12839 12828 -11
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2873 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 880 878 -2
Lines 13037 13026 -11
Branches 3496 3425 -71
==========================================
- Hits 12839 12828 -11
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 599 bytes ⬇️
|
Bundle ReportChanges will decrease total bundle size by 599 bytes ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
=====================================
Coverage 98.48 98.48
=====================================
Files 880 878 -2
Lines 13037 13026 -11
Branches 3429 3493 +64
=====================================
- Hits 12839 12828 -11
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| @@ -14,7 +14,7 @@ export function extractCoverageFromResponse( | |||
| if (!coverageFile) return null | |||
| const lineWithCoverage = keyBy(coverageFile?.coverage, 'line') | |||
| const fileCoverage = mapValues(lineWithCoverage, 'coverage') | |||
| const coverageTotal = coverageFile?.totals?.coverage | |||
There was a problem hiding this comment.
was this a bug fix too?
There was a problem hiding this comment.
Nope, i had originally aliased the field in GQL, this is me removing it now and updating it, with TS makes it easier to find the errors
…ts are selected and migrate to TS
nicholas-codecov
force-pushed
the
gh-eng-355-remove-repository-deprecated-from-use-coverage-with-filters
branch
from
eb9eca4
to
5a7e61a
Compare
nicholas-codecov
deleted the
gh-eng-355-remove-repository-deprecated-from-use-coverage-with-filters
branch
Description
This PR actually removes the
useCoverageWithFiltershook instead replacing it's use with the original hook and extending it to support the features that were specific touseCoverageWithFiltersreducing the chances of actually creating a bug and difference between the two (we weren't fetching the same info for the same use 😬)GH codecov/engineering-team#355
Notable Changes
useCoverageWithFiltersuseFileWithMainCoverageto support new casesuseCommitBasedCoverageForFileViewerto useuseFileWithMainCoverage... twice