-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Small tweak to align with V8 changes #2877
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 880 880
Lines 12957 12957
Branches 3474 3408 -66
=======================================
Hits 12759 12759
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2877 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 880 880
Lines 12957 12957
Branches 3469 3469
=======================================
Hits 12759 12759
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2877 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 880 880
Lines 12957 12957
Branches 3469 3469
=======================================
Hits 12759 12759
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
=====================================
Coverage 98.47 98.47
=====================================
Files 880 880
Lines 12957 12957
Branches 3451 3469 +18
=====================================
Hits 12759 12759
Misses 194 194
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 35 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 35 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
Some unknown changes were made in V8 to the feedback widget, this PR fixes those changes to the styles that were changed in the full release.
Notable Changes