Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small tweak to align with V8 changes #2877

Merged
merged 1 commit into from
May 15, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

Some unknown changes were made in V8 to the feedback widget, this PR fixes those changes to the styles that were changed in the full release.

Notable Changes

  • Small style tweaks

@codecov-qa
Copy link

codecov-qa bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (0a333f0) to head (9896acf).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2877   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         880      880           
  Lines       12957    12957           
  Branches     3474     3408   -66     
=======================================
  Hits        12759    12759           
  Misses        194      194           
  Partials        4        4           
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a333f0...9896acf. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2877   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         880      880           
  Lines       12957    12957           
  Branches     3469     3469           
=======================================
  Hits        12759    12759           
  Misses        194      194           
  Partials        4        4           
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a333f0...9896acf. Read the comment docs.

Copy link

codecov-public-qa bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (0a333f0) to head (9896acf).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2877   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         880      880           
  Lines       12957    12957           
  Branches     3469     3469           
=======================================
  Hits        12759    12759           
  Misses        194      194           
  Partials        4        4           
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a333f0...9896acf. Read the comment docs.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (0a333f0) to head (9896acf).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2877   +/-   ##
=====================================
  Coverage   98.47   98.47           
=====================================
  Files        880     880           
  Lines      12957   12957           
  Branches    3451    3469   +18     
=====================================
  Hits       12759   12759           
  Misses       194     194           
  Partials       4       4           
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a333f0...9896acf. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 35 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.61MB 35 bytes ⬆️

Copy link

codecov bot commented May 14, 2024

Bundle Report

Changes will increase total bundle size by 35 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.61MB 35 bytes ⬆️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
9896acf Tue, 14 May 2024 16:06:58 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 6641399 May 15, 2024
60 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-small-tweaks-to-feedback-widget branch May 15, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants