Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add Ruff to Shared, enable F541 and "I" rules #219

Merged
merged 6 commits into from
May 15, 2024

Conversation

ajay-sentry
Copy link
Contributor

Copy of codecov/codecov-api#555, but for shared.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (6f5b2ba) to head (161858b).

Files Patch % Lines
..._migrations/migrations/legacy_sql/upgrades/main.py 0.00% 1 Missing ⚠️
shared/reports/resources.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         324      324           
  Lines       10395    10395           
  Branches     1813     1813           
=======================================
  Hits         9304     9304           
  Misses       1020     1020           
  Partials       71       71           
Flag Coverage Δ
shared-docker-uploader ?
smart-labels 89.50% <81.81%> (+1.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


[lint]
# Currently only enabled F541: https://docs.astral.sh/ruff/rules/
select = ["F541", "I"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is 1 difference here between the API PR and this one, which is that we are also enabling the isort rules
https://docs.astral.sh/ruff/rules/unsorted-imports/

@ajay-sentry ajay-sentry changed the title dev: Add Ruff to Shared, enable F541 as first rule dev: Add Ruff to Shared, enable F541 and "I" rules May 13, 2024
@ajay-sentry ajay-sentry added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 95c63cd May 15, 2024
9 of 10 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/add-ruff-shared branch May 15, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants