Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changes to account for timeseries migration errors #220

Merged
merged 3 commits into from
May 15, 2024

Conversation

adrian-codecov
Copy link
Contributor

Timeseries table errored out at times because certain tables expected auth and contenttypes initial migration. This change is to add those for new and existing migrations. I also reorganized this a bit to perform migrations for the default and/or timeseries dbs.

Easiest way to review this is to open the file altogether and read it. I created new methods for our default and timeseries dbs to make this easier to read + scale.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.60%. Comparing base (f271d03) to head (fba472e).

❗ Current head fba472e differs from pull request most recent head 9bf97fa. Consider uploading reports for the commit 9bf97fa to get more accurate results

Files Patch % Lines
...s/legacy_migrations/management/commands/migrate.py 90.90% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   89.50%   86.60%   -2.90%     
==========================================
  Files         324      324              
  Lines       10395    10662     +267     
  Branches     1904     1952      +48     
==========================================
- Hits         9304     9234      -70     
- Misses       1020     1326     +306     
- Partials       71      102      +31     
Flag Coverage Δ
shared-docker-uploader ?
smart-labels 86.60% <90.90%> (-2.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nora-codecov
nora-codecov previously approved these changes May 14, 2024
@adrian-codecov adrian-codecov added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 5ada529 May 15, 2024
6 checks passed
@adrian-codecov adrian-codecov deleted the 1687-migrations-error-timeseries branch May 15, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants