Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daniel/parallel upload processing #321

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

daniel-codecov
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@daniel-codecov daniel-codecov force-pushed the daniel/parallel-upload-processing branch from cb238ab to 7a8adee Compare March 15, 2024 14:55
@codecov-qa
Copy link

codecov-qa bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0.93458% with 106 lines in your changes are missing coverage. Please review.

Project coverage is 8.38%. Comparing base (600e403) to head (45d0161).
Report is 12 commits behind head on main.

❗ Current head 45d0161 differs from pull request most recent head d6b7c03. Consider uploading reports for the commit d6b7c03 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #321       +/-   ##
==========================================
- Coverage   98.11%   8.38%   -89.74%     
==========================================
  Files         385     321       -64     
  Lines       31955   25534     -6421     
==========================================
- Hits        31354    2140    -29214     
- Misses        601   23394    +22793     
Flag Coverage Δ
integration 8.38% <0.93%> (-89.74%) ⬇️
latest-uploader-overall 8.38% <0.93%> (-89.74%) ⬇️
unit 8.38% <0.93%> (-89.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 14.98% <0.93%> (-81.26%) ⬇️
OutsideTasks 14.89% <100.00%> (-83.03%) ⬇️
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/upload.py 0.00% <0.00%> (-97.99%) ⬇️
tasks/upload_processor.py 0.00% <0.00%> (-98.27%) ⬇️
tasks/upload_finisher.py 0.00% <0.00%> (-95.94%) ⬇️

... and 366 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Mar 15, 2024

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (600e403) 98.11% compared to head (45d0161) 8.38%.
Report is 12 commits behind head on main.

❗ Current head 45d0161 differs from pull request most recent head d6b7c03. Consider uploading reports for the commit d6b7c03 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #321       +/-   ##
==========================================
- Coverage   98.11%   8.38%   -89.74%     
==========================================
  Files         385     321       -64     
  Lines       31955   25534     -6421     
==========================================
- Hits        31354    2140    -29214     
- Misses        601   23394    +22793     
Flag Coverage Δ
integration 8.38% <0.93%> (-89.74%) ⬇️
latest-uploader-overall 8.38% <0.93%> (-89.74%) ⬇️
unit 8.38% <0.93%> (-89.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 14.98% <0.93%> (-81.26%) ⬇️
OutsideTasks 14.89% <100.00%> (-83.03%) ⬇️
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/upload.py 0.00% <0.00%> (-97.99%) ⬇️
tasks/upload_processor.py 0.00% <0.00%> (-98.27%) ⬇️
tasks/upload_finisher.py 0.00% <0.00%> (-95.94%) ⬇️

... and 366 files with indirect coverage changes

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0.93458% with 106 lines in your changes are missing coverage. Please review.

Project coverage is 91.76%. Comparing base (600e403) to head (45d0161).
Report is 12 commits behind head on main.

❗ Current head 45d0161 differs from pull request most recent head d6b7c03. Consider uploading reports for the commit d6b7c03 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   98.11%   91.76%   -6.35%     
==========================================
  Files         416      414       -2     
  Lines       32655    33225     +570     
==========================================
- Hits        32038    30488    -1550     
- Misses        617     2737    +2120     
Flag Coverage Δ
integration 8.38% <0.93%> (-89.74%) ⬇️
latest-uploader-overall 8.38% <0.93%> (-89.74%) ⬇️
unit 8.38% <0.93%> (-89.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 89.05% <0.93%> (-7.13%) ⬇️
OutsideTasks 14.89% <100.00%> (-83.03%) ⬇️
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/upload.py Critical 89.86% <0.00%> (-8.14%) ⬇️
tasks/upload_processor.py 69.89% <0.00%> (-28.38%) ⬇️
tasks/upload_finisher.py 67.44% <0.00%> (-28.53%) ⬇️

... and 129 files with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.UploadProcessor
run/app.tasks.upload.Upload

@codecov-staging
Copy link

codecov-staging bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0.93458% with 106 lines in your changes are missing coverage. Please review.

Impacted file tree graph

@@          Coverage Diff           @@
##             main    #321   +/-   ##
======================================
  Coverage        ?   8.38%           
======================================
  Files           ?     321           
  Lines           ?   25534           
  Branches        ?       0           
======================================
  Hits            ?    2140           
  Misses          ?   23394           
  Partials        ?       0           
Flag Coverage Δ
integration 8.38% <0.93%> (?)
latest-uploader-overall 8.38% <0.93%> (?)
unit 8.38% <0.93%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 14.98% <0.93%> (?)
OutsideTasks 14.89% <100.00%> (?)
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/upload.py 0.00% <0.00%> (ø)
tasks/upload_processor.py 0.00% <0.00%> (ø)
tasks/upload_finisher.py 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant