Bugfix for hg clone failing when using custom installation path #11212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb-relaxt-at
changed the title
|
The fix done here is not the one suggested in the discussion in the issue. any reason for that ? |
|
Thanks for your feedback. This solution has been implemented prior the ongoing conversation and has been tested for some time. I will give the different approach (not passing a cwd) a try and update the PR as soon as I have tested it. |
|
I don't think a realpath here is a good solution, as if the dir doesn't exist yet it'll return false, which would be definitely a bad outcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed bugfix for #10123