Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC 14.1 & 13.3 #133

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

GCC 14.1 & 13.3 #133

wants to merge 13 commits into from

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented May 7, 2024

Freshly released: 14.1, 13.3

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@conda-forge/ctng-compilers, this is ready for review! Point releases for the maintenance branches should show up towards the end of May.

@h-vetinari
Copy link
Member Author

Ah, we might want to fix #126 here already.

@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member Author

Not sure what's up after #130, but I cannot rerender locally anymore.

  File "E:\miniforge\envs\builder\Lib\site-packages\conda_smithy\feedstock_io.py", line 55, in write_file
    with io.open(filename, "w", encoding="utf-8", newline="\n") as fh:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\[xxx]\\dev\\conda-forge\\ctng-compilers-feedstock\\.ci_support\\linux_aarch64_cross_target_platformlinux-64cross_target_stdlibsysrootcross_target_stdlib_version2.12gcc_maj_ver11gcc_version11.4.0old_tripletx86_64-conda_cos6-linux-gnutripletx86_64-conda-linux-gnu.yaml'

Might be running into path length limitations on windows...

At least the bot still can. :)

@h-vetinari
Copy link
Member Author

@isuruf, unsurprisingly, the mingw patches from #130 fail against GCC 14. What would you like to do here - carry two sets of patches, or build mingw only against GCC 13 (or only against 14)?

@isuruf
Copy link
Member

isuruf commented May 13, 2024

We can carry two sets in recipe/patches/mingw/13 and recipe/patches/mingw/14

@h-vetinari
Copy link
Member Author

@conda-forge/ctng-compilers, this should be ready for review. We might want to link the C++ chrono implementation to a tzdb we supply ourselves (with tzdata; see #126), but for now this is a vanilla upgrade.

@h-vetinari h-vetinari changed the title GCC 14.1 GCC 14.1 & 13.3 May 21, 2024
@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member Author

This now also contains 13.3 & the tzdb fix. PTAL @conda-forge/ctng-compilers :)

@isuruf
Copy link
Member

isuruf commented May 22, 2024

Thanks. 13.3 build fails to apply the patches though.

@isuruf
Copy link
Member

isuruf commented May 22, 2024

For tzdb, can you add a test? Binary prefix relocation usually don't work when the prefix is stored in a std::string.

@h-vetinari
Copy link
Member Author

h-vetinari commented May 22, 2024

Thanks. 13.3 build fails to apply the patches though.

Yeah, one of the mingw patches appeared in 13.3 and needs to be dropped.

For tzdb, can you add a test? Binary prefix relocation usually don't work when the prefix is stored in a std::string.

How do you imagine that test to look like? I imagine it'll be a bit hard to prove 100% that it gets taken from the specified location, since we also have a copy of tzdata in the sysroot: conda-forge/linux-sysroot-feedstock#62.

I can compile an example that fetches something from the tzdb, is that enough?

As noted in #126, we could in principle also define zoneinfo_dir_override (see here), though I don't know how that would work in practice (where that weak symbol needs to be defined/implemented/shipped). If we do that, we could implement that function so that it always prefers $CONDA_PREFIX/share/zoneinfo (and loads the env var at runtime), so we'd avoid the binary relocation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants