Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-cudnn-frontend #26370

Merged
merged 5 commits into from
May 24, 2024
Merged

Add python-cudnn-frontend #26370

merged 5 commits into from
May 24, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented May 15, 2024

The cuDNN FrontEnd(FE) API is a C++ header-only library that wraps the cuDNN C backend API. Repo at https://github.com/NVIDIA/cudnn-frontend

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

The cuDNN FrontEnd(FE) API is a C++ header-only library that wraps the cuDNN C backend API. Repo at https://github.com/NVIDIA/cudnn-frontend
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cudnn-frontend) and found some lint.

Here's what I've got...

For recipes/cudnn-frontend:

  • The home item is expected in the about section.
  • If python is a host requirement, it should be a run requirement.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/cudnn-frontend:

Also add stdlib-c, and about-home.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cudnn-frontend) and found it was in an excellent condition.

@weiji14 weiji14 mentioned this pull request May 15, 2024
10 tasks
@weiji14 weiji14 marked this pull request as ready for review May 15, 2024 20:44
@weiji14
Copy link
Member Author

weiji14 commented May 15, 2024

@conda-forge/help-python-c, ready for review!

@xhochy
Copy link
Member

xhochy commented May 17, 2024

If this is a header-only library, why does it need Python?

@weiji14
Copy link
Member Author

weiji14 commented May 17, 2024

This is built with the Python bindings (https://github.com/NVIDIA/cudnn-frontend?tab=readme-ov-file#python-api). I could try to remove python from the host and runtime deps and see if it works?

@xhochy
Copy link
Member

xhochy commented May 17, 2024

It depends on what you want to achieve with this package. If it should be one for the headers, you should remove python. If you want to have the Python bindings, then this looks good.

@weiji14
Copy link
Member Author

weiji14 commented May 17, 2024

Yes, I'll be using this with the python bindings. Should I add a -python suffix perhaps?

@xhochy
Copy link
Member

xhochy commented May 18, 2024

Yes, I'll be using this with the python bindings. Should I add a -python suffix perhaps?

For these cases, we normally add a python- prefix.

@weiji14 weiji14 changed the title Add cudnn-frontend Add python-cudnn-frontend May 18, 2024
- {{ compiler('cuda') }}
- {{ stdlib("c") }}
- cmake >=3.17
- cudnn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in host and then you probably don't need to explicitly mention it in run anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should solely be in host, i.e. should also not appear in build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done! Thanks again for checking 😃

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cudnn-frontend) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cudnn-frontend:

  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@weiji14
Copy link
Member Author

weiji14 commented May 20, 2024

In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

Guessing that this is a false alarm since there's no conda_build_config.yaml file added? Can probably just ignore also since this recipe won't be built on macOS.

@xhochy xhochy merged commit 571d841 into conda-forge:main May 24, 2024
7 checks passed
@weiji14 weiji14 deleted the add-cudnn-frontend branch May 24, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants