-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python-cudnn-frontend #26370
Add python-cudnn-frontend #26370
Conversation
The cuDNN FrontEnd(FE) API is a C++ header-only library that wraps the cuDNN C backend API. Repo at https://github.com/NVIDIA/cudnn-frontend
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cudnn-frontend:
For recipes/cudnn-frontend:
|
Also add stdlib-c, and about-home.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python-c, ready for review! |
If this is a header-only library, why does it need Python? |
This is built with the Python bindings (https://github.com/NVIDIA/cudnn-frontend?tab=readme-ov-file#python-api). I could try to remove |
It depends on what you want to achieve with this package. If it should be one for the headers, you should remove python. If you want to have the Python bindings, then this looks good. |
Yes, I'll be using this with the python bindings. Should I add a |
For these cases, we normally add a python- prefix. |
recipes/cudnn-frontend/meta.yaml
Outdated
- {{ compiler('cuda') }} | ||
- {{ stdlib("c") }} | ||
- cmake >=3.17 | ||
- cudnn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in host and then you probably don't need to explicitly mention it in run anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should solely be in host, i.e. should also not appear in build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done! Thanks again for checking 😃
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/cudnn-frontend:
|
Guessing that this is a false alarm since there's no |
The cuDNN FrontEnd(FE) API is a C++ header-only library that wraps the cuDNN C backend API. Repo at https://github.com/NVIDIA/cudnn-frontend
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).