Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conda-recipe-manager as a conda-forge feedstock #26371

Merged
merged 10 commits into from
May 31, 2024

Conversation

schuylermartin45
Copy link
Contributor

  • This will allow us to start publishing versions that others can consume
  • The most immediate need is for an ask in Grayskull

Checklist

  • [ x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [ x] License file is packaged (see here for an example).
  • [ x] Source is from official source.
  • [ x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [ x] If static libraries are linked in, the license of the static library is packaged.
  • [ x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [ x] Build number is 0.
  • [ x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [ x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [ x] When in trouble, please check our knowledge base documentation before pinging a team.

- This will allow us to start publishing versions that others can consume
- The most immediate need is for an [ask in Grayskull](conda/grayskull#486)
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-recipe-manager) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-recipe-manager) and found some lint.

Here's what I've got...

For recipes/conda-recipe-manager:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-recipe-manager) and found some lint.

Here's what I've got...

For recipes/conda-recipe-manager:

  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-recipe-manager) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-recipe-manager) and found some lint.

Here's what I've got...

For recipes/conda-recipe-manager:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-recipe-manager) and found it was in an excellent condition.

@schuylermartin45
Copy link
Contributor Author

@conda-forge/help-python I believe this is ready for review. Thanks!

@@ -0,0 +1,32 @@
BSD 3-Clause License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file is already in the source distribution you're using so you shouldn't include an additional copy of it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm confused then because every piece of documentation I saw says to include it with the recipe file. I thought that was standard practice.

# It is strongly encouraged to include a license file in the package,
# (even if the license doesn't require it) using the license_file entry.
# See http://conda.pydata.org/docs/building/meta-yaml.html#license-file
license_file: LICENSE.txt

  # It is strongly encouraged to include a license file in the package,
  # (even if the license doesn't require it) using the license_file entry.
  # See http://conda.pydata.org/docs/building/meta-yaml.html#license-file
  license_file: LICENSE.txt

https://conda-forge.org/docs/maintainer/adding_pkgs/#the-staging-process

With the help of the staging process, add a package's recipe and license to the staged-recipes repository and create a PR.

https://conda-forge.org/docs/maintainer/adding_pkgs/#checklist

Ensure that you have included a license file if your license requires one – most do. (see here)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, you are correct that this means that it should be included. Most packages package the license file in the source distribution, the file then just needs to list it in the meta.yaml and it is included. You only need to manually include the license file if it isn't included.
So the difference comes from including the actual file (which is often not necessary) and including the path to the file (which is always necessary).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! Maybe the docs or linter could be improved to reflect that nuance?

Either way, I just removed the file in the latest commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think there is an issue for that, we just haven't gotten around to it... 😄

@schuylermartin45
Copy link
Contributor Author

I'm not sure how to get the bot to change the label, but I, as the author, made a contribution last week and I don't think the label is accurate anymore.

@BastianZim BastianZim merged commit 270958e into conda-forge:main May 31, 2024
5 checks passed
@BastianZim
Copy link
Member

For the future, you can just change the label by requesting a review again using @ conda-forge/help-python

@schuylermartin45 schuylermartin45 deleted the smartin_crm_feedstock branch May 31, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants