Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ultrack #26372

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add ultrack #26372

wants to merge 7 commits into from

Conversation

JoOkuma
Copy link
Member

@JoOkuma JoOkuma commented May 15, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (ultrack) and found some lint.

Here's what I've got...

For ultrack:

  • The home item is expected in the about section.
  • The summary item is expected in the about section.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.
  • The following maintainers have not yet confirmed that they are willing to be listed here: ilan-theodoro. Please ask them to comment on this PR if they are.

@JoOkuma
Copy link
Member Author

JoOkuma commented May 15, 2024

@ilan-theodoro, do you agree to be a maintainer of this conda recipe?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (ultrack) and found some lint.

Here's what I've got...

For ultrack:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.
  • The following maintainers have not yet confirmed that they are willing to be listed here: ilan-theodoro. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ultrack) and found some lint.

Here's what I've got...

For recipes/ultrack:

  • The top level meta key channel_targets is unexpected
  • The following maintainers have not yet confirmed that they are willing to be listed here: ilan-theodoro. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ultrack) and found some lint.

Here's what I've got...

For recipes/ultrack:

  • The following maintainers have not yet confirmed that they are willing to be listed here: ilan-theodoro. Please ask them to comment on this PR if they are.

@ilan-theodoro
Copy link

🔥

@@ -17,7 +17,7 @@ cgo_compiler:
target_platform:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not modify these files under .ci_support. You should only be adding files under the recipe directory that you are building the package for. Additionally any dependencies need to be pulled in from the conda-forge channel. If it's not available, then that package needs to be added to conda-forge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@synapticarbors thank you for the feedback.

gurobi is a closed-source package from a private company. I think it's very unlikely they will include it in conda-forge since they have their own gurobi channel.

Does that mean I won't be able to add my package to conda-forge? If so, do you have any suggestions for uploading it to conda? Maybe I should create my own channel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants