Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding recipe for biomechanical-analysis-framework package #26377

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

davidegorbani
Copy link

@davidegorbani davidegorbani commented May 16, 2024

This PR adds the recipe for the library biomechanical-analysis-framework, which is a library that estimates the kinematics and dynamics quantities of a human.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biomechanical-analysis-framework) and found it was in an excellent condition.

@davidegorbani
Copy link
Author

CC @traversaro

@traversaro
Copy link
Contributor

CI error is:

conda_build.exceptions.OverLinkingError: overlinking check failed 
["  ERROR (libbiomechanical-analysis-framework,lib/libBiomechanicalAnalysisFrameworkLogging.so.0.0.1): .. but ['conda-forge/linux-64::libbipedal-locomotion-framework==0.18.0=h77cefc7_9'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)", "  ERROR (libbiomechanical-analysis-framework,lib/libBiomechanicalAnalysisFrameworkIK.so.0.0.1): .. but ['conda-forge/linux-64::libbipedal-locomotion-framework==0.18.0=h77cefc7_9'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)", "  ERROR (libbiomechanical-analysis-framework,lib/libBiomechanicalAnalysisFrameworkIK.so.0.0.1): .. but ['conda-forge/linux-64::libbipedal-locomotion-framework==0.18.0=h77cefc7_9'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)", "  ERROR (libbiomechanical-analysis-framework,lib/libBiomechanicalAnalysisFrameworkIK.so.0.0.1): .. but ['conda-forge/linux-64::libbipedal-locomotion-framework==0.18.0=h77cefc7_9'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)", "  ERROR (libbiomechanical-analysis-framework,lib/libBiomechanicalAnalysisFrameworkIK.so.0.0.1): .. but ['conda-forge/linux-64::libbipedal-locomotion-framework==0.18.0=h77cefc7_9'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)", "  ERROR (libbiomechanical-analysis-framework,lib/libBiomechanicalAnalysisFrameworkIK.so.0.0.1): .. but ['conda-forge/linux-64::fmt==10.2.1=h00ab1b0_0'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)", "  ERROR (libbiomechanical-analysis-framework,lib/libBiomechanicalAnalysisFrameworkTextLoggingYarpImplementation.so.0.0.1): .. but ['conda-forge/linux-64::libbipedal-locomotion-framework==0.18.0=h77cefc7_9'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)"]

Why? Basically bipedal-locomotion-framework is the meta package that installs both C++ and Python bindings of bipedal-locomotion-framework . To let know to conda that you are actually building against bipedal-locomotion-framework's C++ library, keep libbipedal-locomotion-framework, that has the correct run_exports, see https://github.com/conda-forge/bipedal-locomotion-framework-feedstock/blob/main/recipe/meta.yaml#L27 .

davidegorbani and others added 3 commits May 16, 2024 14:26
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
davidegorbani and others added 2 commits May 16, 2024 14:31
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biomechanical-analysis-framework) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/biomechanical-analysis-framework:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biomechanical-analysis-framework) and found it was in an excellent condition.

- libbipedal-locomotion-framework>=0.18.0
- xorg-libxfixes # [linux]
run:
- libbipedal-locomotion-framework>=0.18.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no needed, as the libbipedal-locomotion-framework recipe has a run_exports in its recipe that will automatically make sure that the correct run dependency is added in the resulting recipe (see https://github.com/conda-forge/bipedal-locomotion-framework-feedstock/blob/28e0a93a0ba93841cf3215be2a2098ad5d5a25e5/recipe/meta.yaml#L26-L27 and https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#export-runtime-requirements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants