Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SCSD #26380

Closed
wants to merge 7 commits into from
Closed

Adding SCSD #26380

wants to merge 7 commits into from

Conversation

Alex-AMC
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/scsd) and found some lint.

Here's what I've got...

For recipes/scsd:

  • The license item is expected in the about section.
  • The following maintainers have not yet confirmed that they are willing to be listed here: cjkingsbury. Please ask them to comment on this PR if they are.

@cjkingsbury
Copy link

I'm happy to be associated as maintainer

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/scsd) and found some lint.

Here's what I've got...

For recipes/scsd:

  • The license item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/scsd) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/scsd:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

about:
home: https://github.com/cjkingsbury/scsd
summary: 'SCSD is Python software for the analysis of molecular conformation and deformation in crystal structures'
license: ACSL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can redistribute packages under this license.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a feeling this was going to be the case. Thank you for the quick reply :)

@Alex-AMC Alex-AMC closed this May 20, 2024
@Alex-AMC Alex-AMC deleted the scsd_staging_recipe branch May 20, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants