Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for toksearch package #26387

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

smithsp
Copy link
Contributor

@smithsp smithsp commented May 16, 2024

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your
    recipe (see
    here
    for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

Mention @sammuli

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/toksearch) and found some lint.

Here's what I've got...

For recipes/toksearch:

  • The home item is expected in the about section.
  • The license item is expected in the about section.
  • The summary item is expected in the about section.
  • There are too few lines. There should be one empty line at the end of the file.
  • The following maintainers have not yet confirmed that they are willing to be listed here: sammuli. Please ask them to comment on this PR if they are.
  • requirements: host: numpy>=1.20 must contain a space between the name and the pin, i.e. numpy >=1.20
  • requirements: run: mdsplus=7.7 must contain a space between the name and the pin, i.e. mdsplus =7.7
  • requirements: run: numpy>=1.20 must contain a space between the name and the pin, i.e. numpy >=1.20
  • requirements: run: joblib>=1.3 must contain a space between the name and the pin, i.e. joblib >=1.3

For recipes/toksearch:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/toksearch) and found some lint.

Here's what I've got...

For recipes/toksearch:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].
  • license_file entry is missing, but is required.
  • The following maintainers have not yet confirmed that they are willing to be listed here: sammuli. Please ask them to comment on this PR if they are.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/toksearch:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/toksearch) and found some lint.

Here's what I've got...

For recipes/toksearch:

  • The following maintainers have not yet confirmed that they are willing to be listed here: sammuli. Please ask them to comment on this PR if they are.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@smithsp
Copy link
Contributor Author

smithsp commented May 17, 2024

@sammuli Please check the failing tests here. Maybe there is a missing dependency in the test or run section?

@sammuli
Copy link

sammuli commented May 17, 2024

Oh - I see what's happening. The spark related tests need java in the test environment (and JAVA_HOME set appropriately).

@smithsp
Copy link
Contributor Author

smithsp commented May 20, 2024

@sammuli I added you to https://github.com/smithsp/staged-recipes so you can push changes to this branch directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants