Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spcqe recipe #26391

Merged
merged 3 commits into from
May 22, 2024
Merged

Adding spcqe recipe #26391

merged 3 commits into from
May 22, 2024

Conversation

pluflou
Copy link
Contributor

@pluflou pluflou commented May 17, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/spcqe) and found it was in an excellent condition.

@synapticarbors
Copy link
Member

The error on this one is strange. pip check is failing with:

+ pip check
spcqe 0.0.1a0 requires cvxpy, which is not installed.

but if you look at the output of what's being installed it includes:

cvxpy:            1.5.1-py312h7900ff3_0               conda-forge
cvxpy-base:       1.5.1-py312h266a736_0               conda-forge

See: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=936210&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=881

@conda-forge/staged-recipes -- does anyone else understand what might be going wrong here?

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@pluflou
Copy link
Contributor Author

pluflou commented May 19, 2024

@synapticarbors seems likely a cvxpy packaging issue--I opened an issue here. Meanwhile I plan to adjust the tests in the recipe to move this along but I haven't gotten to it yet.

@pluflou
Copy link
Contributor Author

pluflou commented May 21, 2024

I pinned the cvxpy version to the latest that works with conda until issue #2447 is resolved. @conda-forge/help-python this ready for review!

@synapticarbors
Copy link
Member

@pluflou -- Sorry for the delay getting back to you on this. I would actually suggest commenting out the pip check until the upstream issue is fixed. We probably don't want to pin a package to a specific version when it's not in the upstream version requirements. You could then re-enable the pip check when the issue with cvxpy is fixed.

@pluflou
Copy link
Contributor Author

pluflou commented May 22, 2024

@synapticarbors makes sense. Done! Thank you :)

@synapticarbors synapticarbors merged commit f47154d into conda-forge:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants