Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thomas Dillard - Frontend Challenge #83

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Thomas Dillard - Frontend Challenge #83

wants to merge 15 commits into from

Commits on Mar 20, 2023

  1. Add /frontend .gitignore because of VSCode bug 

    Added this .gitignore as a temp fix, when I open sub directories and
their parent repositories the `.yarn/cache` was still populating. This
may be a configuration issue with the `.gitignore`.
    @indifferentghost
    indifferentghost committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    41ab472 View commit details
    Browse the repository at this point in the history

  2. Update testing packages - see Next.js docs 

    Updated example includes adding jest-environment-dom.
Added testing-library for its ease-of-use and prevalence in
the industry.
    @indifferentghost
    indifferentghost committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e69ef77 View commit details
    Browse the repository at this point in the history

  3. Add inert polyfill

    @indifferentghost
    indifferentghost committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0743070 View commit details
    Browse the repository at this point in the history

  4. Basic working modal no background color.

    @indifferentghost
    indifferentghost committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    f0401e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Update styles

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    dd50af0 View commit details
    Browse the repository at this point in the history

  2. Add escape functionality

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    9877b08 View commit details
    Browse the repository at this point in the history

  3. Abstract use-isomorphic-layout

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1ef8af5 View commit details
    Browse the repository at this point in the history

  4. refactor focus trap

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0858f15 View commit details
    Browse the repository at this point in the history

  5. add callback to escape trap dependencies

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f70f014 View commit details
    Browse the repository at this point in the history

  6. Add state to index.js example

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    61e0d06 View commit details
    Browse the repository at this point in the history

  7. Cleanup fix styling add onClose handler

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    afea807 View commit details
    Browse the repository at this point in the history

  8. remove unused inert polyfill

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    56d3d2e View commit details
    Browse the repository at this point in the history

  9. Add tests

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0c97776 View commit details
    Browse the repository at this point in the history

  10. Further cleanup of data, moving example text

    @indifferentghost
    indifferentghost committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    27275f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Lint with prettier

    @indifferentghost
    indifferentghost committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    db7ee07 View commit details
    Browse the repository at this point in the history