Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camilo Barraza - Frontend #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

camilo-barraza
Copy link

@camilo-barraza camilo-barraza commented Apr 15, 2023

Frontend assessment

Description

  • Add styled-components configuration
  • Add Modal and Button components
  • Add index page with demo for Modals

Deployed App

https://contra-interview-assessment-9s2xfqsgy-camilo-barraza.vercel.app/

Demo

https://www.loom.com/share/1d585cbc282e43ab8dca87bf5bdfd8d1

Code Review

https://www.loom.com/share/b2c27c25345f45ab8a32eed2bc153811

Loom Summary

  • Review Index component that contains buttons and modals and extensibility of components
  • Styles configuration based on styled-components and reusable css that can be shared across apps
  • Developer experience review based on styled-components configuration with TS

Notes

  • Added a flexible eslintrc config so I could build something fast based on the config I already had.
  • Didn't test multiple stacked modals since more than 2 is bad UX

Comments

I've shared my configuration for styled components that I've used on several projects and I believe it's both easy to manage and extend. I'm always looking to improve it, and I welcome any feedback to make it better. While I'm comfortable working with any configuration for styling in React projects, my goal is ensuring a positive developer experience that allows us to easily update, review, and manage our code, all while enjoying the development process.

My Linkeind profile

https://www.linkedin.com/in/camilo-barraza/

- add Modal and Button components
- add index page with demo for Modals
@camilo-barraza camilo-barraza changed the title Add Config and Modal component Camilo Barraza - Frontend Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant