create separate package for @graphql-helix/core #140
Conversation
|
@n1ru4l is there anything I can do to move this forward? |
|
@mosch, I did not have a look yet, but will on Thursday. Can you rebase upon master until then? |
# Conflicts: # packages/core/package.json
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/graphql-helix/graphql-helix/DUwDk1qFoZ7hKWmQNRTdXUCwiW1s |
| @@ -1,5 +1,5 @@ | |||
| import express, { RequestHandler } from "express"; | |||
| import { getGraphQLParameters, processRequest, renderGraphiQL, sendResult, shouldRenderGraphiQL } from "../../lib"; | |||
| import { getGraphQLParameters, processRequest, renderGraphiQL, sendResult, shouldRenderGraphiQL } from "../../../graphql-helix"; | |||
There was a problem hiding this comment.
I think we should move this folder (test/implementations) to packages/graphql-helix.
| @@ -1,8 +1,2 @@ | |||
| export * from "./get-graphql-parameters.ts"; | |||
| export * from "./process-request.ts"; | |||
| export * from "@graphql-helix/core DENOIFY: DEPENDENCY UNMET (BUILTIN)"; | |||
There was a problem hiding this comment.
This warning seems dangerous? DENOIFY: DEPENDENCY UNMET (BUILTIN)
I am actually not really aware of all the deno shenanigans, it might be worth adding a deno integration test suite in a separate PR first, so we can verify this PR does not break the behavior?
|
@mosch Shouldn't the be also a |
|
Since @mosch probably will be out for a while, I might as well take this over. Thanks ✌️ edit: (don't know why vercel tests fail) |
|
Deployment failed with the following error: |
|
Hey @dan-lee, sorry for letting this slip so long. Do you mind rebasing and finishing this PR? Let's finish this and release it. |
Hey there,
we have done our best to solve the package size issue.
This may not be complete, especially around the deno packages.
Looking for some early feedback on this one 🤞🏻 @n1ru4l @talentlessguy @danielrearden