Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted non-related controller method into Croogo Libraries. #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extracted non-related controller method into Croogo Libraries. #586

wants to merge 1 commit into from

Conversation

damien-biasotto
Copy link
Member

Title is kind of explicit. I may be add some tests later to cover newly created methods.

@scrutinizer-notifier
Copy link

The inspection completed: 12 new issues, 4 updated code elements

@rchavik
Copy link
Member

rchavik commented Dec 2, 2014

Hmm. I don't really like this one.

  • Although the menu setup code is weird to have there, I don't see much value of moving those code into a specialized method in the CroogoNav class. Maybe we can add a new event instead and have a listener to handle it.
  • The although rename of roleId() to getCurrentUserRoleId(), I also feel this is too verbose and might be better served if we have a separate Component for this, eg CroogoSession under Acl. Hmm, maybe for 2.3.

@rchavik rchavik added this to the 2.3.1 milestone Dec 6, 2017
@rchavik rchavik added this to Needs triage in 4.1 Nov 25, 2019
@rchavik rchavik moved this from Needs triage to Low priority in 4.1 Nov 26, 2019
@rchavik rchavik removed this from the 2.3.1 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4.1
  
Low priority
Development

Successfully merging this pull request may close these issues.

None yet

3 participants