-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 api: align Container.withNewFile
signature with Directory.withNewFile
#7293
base: main
Are you sure you want to change the base?
💥 api: align Container.withNewFile
signature with Directory.withNewFile
#7293
Conversation
9bfb361
to
8fcad31
Compare
The consistency argument is pretty compelling. If it was a good idea in |
8fcad31
to
f26353d
Compare
…ile` Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
f26353d
to
bf3e9f3
Compare
* @param opts.permissions Permission given to the written file (e.g., 0600). | ||
* @param opts.owner A user:group to set for the file. | ||
* | ||
* The user and group can either be an ID (1000:1000) or a name (foo:bar). | ||
* | ||
* If the group is omitted, it defaults to the same as the user. | ||
*/ | ||
withNewFile = (path: string, opts?: ContainerWithNewFileOpts): Container => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I can confirm this is a breaking change for TypeScript.
The parameter contents
moved from a struct param into a require unary parameter.
Warning
This is a breaking change in Go and TypeScript1! 💥
Deprecation path not possible. May want to hold merge for v0.12.0.
Fixes #6961
Brings more consistency. We made
contents
mandatory inDirectory.withNewFile
but not inContainer.withNewFile
:contents
mandatory #3911Footnotes
May need to double check on TS. Not a breaking change for Python. ↩