Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

fix: use latest dat-node for network improvements with hyperswarm #649

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okdistribute
Copy link
Collaborator

Contributor checklist:

  • My commits are in nice logical chunks with good commit messages
  • If my changes depend upon an update to a dependency, I have updated the package-lock.json file using npm install --package-lock
  • I have used the app myself and all of the buttons work.
  • I have tested the application with the commandline
    tool
    .
  • My changes have been tested with the integration tests, and all tests pass.
  • My changes are ready to be shipped to users on Mac and Linux.

Description

Better connectivity: A better DHT and holepunching. The networking stack has been entirely rewritten. See https://github.com/hyperswarm/hyperswarm

@okdistribute
Copy link
Collaborator Author

fixes #648

@decentral1se
Copy link

decentral1se commented Mar 31, 2020

Built binaries for easier testing: http://vvvvvvaria.org/~luke/dat-desktop%40next.tar.gz
EDIT: mac os version @ https://vvvvvvaria.org/~luke/ddmac.zip

@decentral1se
Copy link

OK, so the changes are good, I was able to build, LGTM!

Bad news is that I still can't share files with this new networking... will try to debug...

@decentral1se
Copy link

decentral1se commented Mar 31, 2020

Oh wait, it worked! I tried the dat@next cli and it worked for sharing 🎂

My friend was using my binary for dat-desktop and I was using the dat@next cli. Perhaps I built the binaries incorrectly (it was quite hard in the end...) So, I would say that it will be nice when this is merged and someone who knows what they are doing can publish the new binaries with these changes included.

Thanks again for the work!

Copy link
Collaborator

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this PR on a windows and mac computer. Both were able to build and start. Creating a folder worked and shared it. Downloading the folder on the other computer found the peer but didn't start synching.

@decentral1se
Copy link

Thanks for testing @martinheidegger!

Branch is rotting, oh oh, any bump on getting this merged in once rebased?

Thanks and sorry for nagging (but it is gentle, I hope ;))

@martinheidegger
Copy link
Collaborator

@decentral1se I wish it would work, then the merging was a no-brainer.

@okdistribute
Copy link
Collaborator Author

Is this a bug with this branch or is it also reproducible on master @martinheidegger ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants