Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add chunking api interface to management canister #1768

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

add chunking api interface to management canister #1768

wants to merge 9 commits into from

Conversation

sudoshreyansh
Copy link
Contributor

No description provided.

@lastmjs
Copy link
Member

lastmjs commented May 2, 2024

Please follow these instructions: https://github.com/demergent-labs/azle?tab=readme-ov-file#contributing

@lastmjs
Copy link
Member

lastmjs commented May 2, 2024

If you are able to sign the license extension, I would like to ask for tests to be added to this PR as well. Most of our management canister tests are here: https://github.com/demergent-labs/azle/tree/main/examples/management_canister

You would need to add whatever extra functionality you've added to the management canister to this example similar to the other APIs in there, and add the tests as well.

That's all basic feedback before a thorough review.

@sudoshreyansh
Copy link
Contributor Author

Sure! I have signed the license #1771
I have added the examples and tests. I will also update the Azle book docs and mark this ready for review.

@sudoshreyansh sudoshreyansh marked this pull request as ready for review May 3, 2024 13:46
@lastmjs
Copy link
Member

lastmjs commented May 3, 2024

Great I have merged the license extension signature and am now running the tests. Will review in the next few days.

lastmjs
lastmjs requested changes May 7, 2024
View reviewed changes
canisters/management/canister_management.ts Show resolved Hide resolved
examples/management_canister/src/index.ts Outdated Show resolved Hide resolved
examples/management_canister/src/index.ts Outdated Show resolved Hide resolved
examples/management_canister/src/index.ts Outdated Show resolved Hide resolved
examples/management_canister/src/index.ts Show resolved Hide resolved
the_azle_book/src/reference/management_canister/clear_chunk_store.md Show resolved Hide resolved
@lastmjs
Copy link
Member

lastmjs commented May 7, 2024

I've reviewed everything but the tests themselves, looking good so far just a few basic changes requested.

@lastmjs
Copy link
Member

lastmjs commented May 7, 2024

I've finished my review, requesting a few changes, very impressed and thanks for the help!

@lastmjs
Copy link
Member

lastmjs commented May 7, 2024

Actually, there is another problem. You can ignore the other tests, but the bitcoin tests are failing and I don't believe they should be. It probably has something to do with updating the ic.did file. If you could address that so they are passing it would be great.

@sudoshreyansh
Copy link
Contributor Author

Yeah, @lastmjs you were right regarding the bitcoin tests. Fixed it.
Also addressed the other requested changes.

@sudoshreyansh
Copy link
Contributor Author

Hey, @lastmjs can you re-review when you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs Awaiting requested review from lastmjs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sudoshreyansh @lastmjs