Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite #1770

Merged
merged 20 commits into from
Jun 7, 2024
Merged

Sqlite #1770

merged 20 commits into from
Jun 7, 2024

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented May 2, 2024

No description provided.

@lastmjs
improving the sqlite example, create and read and batch create in place
6b211df
@lastmjs
add tests to sqlite example, add batch creation script
aef35bd
@lastmjs
add drizzle example, refactor sqlite example, make things cleaner and…
dbbc81e 
… better
@lastmjs
add sqlite_drizzle to test.yml, add posts with tests to sqlite example
5d66cfd
@lastmjs
update and improve
6c13857
@lastmjs
add functionality and tests for updating
7ae5677
@lastmjs
add deleting
081a30a
@lastmjs
get rid of the need to use setNodeServer in Servers with custom init …
bb5d792 
…or post upgrade
@lastmjs
add _azleInitCalled and _azlePostUpgrade called as basic functionalit…
947ca05 
…y everywhere
@lastmjs
reorganize at the highest level
b4aed27
@lastmjs
implement cool little sqlite template tag literal thing
24c4373
@lastmjs
drizzle tests passing! Drizzle refactored mostly to be like sqlite
8adb0fe
@lastmjs
clean up the drizzle example
10e611a
@lastmjs
clean up a bit
4fa1ef8
@lastmjs lastmjs marked this pull request as ready for review May 3, 2024 22:23
@bdemann bdemann changed the base branch from main to nestjs May 7, 2024 16:39
@bdemann bdemann changed the base branch from nestjs to main May 7, 2024 17:21
@bdemann bdemann changed the base branch from main to nestjs May 7, 2024 17:22
@lastmjs lastmjs changed the base branch from nestjs to main May 7, 2024 19:57
bdemann
bdemann requested changes May 7, 2024
View reviewed changes
Copy link
Member

@bdemann bdemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other ideas for things to test

  • Transactions
  • Rolling back?
  • Indexes
  • Subqueries
  • Aggregate functions like SUM, AVG, MIN, MAX
  • Group by
  • Applying multiple migrations

examples/hybrid_canister/src/server_init_and_post_upgrade.ts Outdated Show resolved Hide resolved
examples/sqlite/src/server/index.ts Show resolved Hide resolved
examples/sqlite_drizzle/src/entities/posts/db.ts Show resolved Hide resolved
examples/sqlite_drizzle/src/entities/users/db.ts Show resolved Hide resolved
examples/sqlite/src/entities/users/db.ts Outdated Show resolved Hide resolved
examples/sqlite/src/entities/posts/db.ts Outdated Show resolved Hide resolved
examples/sqlite/test/tests.ts Outdated Show resolved Hide resolved
examples/sqlite/test/tests.ts Outdated Show resolved Hide resolved
examples/sqlite/test/tests.ts Outdated Show resolved Hide resolved
@lastmjs lastmjs merged commit 4ffdeae into main Jun 7, 2024
125 of 128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lastmjs @bdemann