Sqlite typeorm #1774
Open
Sqlite typeorm #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemann
requested changes
May 7, 2024
| import { Post } from '../entities/posts/db'; | ||
| import { User } from '../entities/users/db'; | ||
|
|
||
| // TODO figure out migrations |
There was a problem hiding this comment.
Does this TODO need to be addressed as part of this PR?
src/lib/globals.ts
Outdated
There was a problem hiding this comment.
I mean obviously not, but I thought we already had this
examples/sqlite_typeorm/src/index.ts
Outdated
There was a problem hiding this comment.
Abstracting this would be nice if it doesn't abuse JS too much
| @@ -487,11 +487,11 @@ function postsTestsAfterBatch(origin: string): Test[] { | |||
| { | |||
| name: '/posts not empty', | |||
| test: async () => { | |||
| const response = await fetch(`${origin}/posts?limit=300`); | |||
| const response = await fetch(`${origin}/posts?limit=200`); | |||
There was a problem hiding this comment.
Why are these 200 now instead of 300? Can they be a const instead of a magic number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.