fix resolver order #433
Open
fix resolver order #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luxzeitlos
force-pushed
the
fix-resolver-order
branch
2 times, most recently
from
5915871
to
35aa4c4
Compare
davewasmer
approved these changes
Feb 19, 2018
|
Good catch! Any chance you'd be able to add a test for this? |
luxzeitlos
force-pushed
the
fix-resolver-order
branch
from
35aa4c4
to
b9688ea
Compare
|
haz test now 🍵 |
luxzeitlos
force-pushed
the
fix-resolver-order
branch
from
b9688ea
to
0343094
Compare
|
Whats the status here? this has been fixed on master independent of this PR. Maybe close the PR, or should I rebase to just take the test? |
|
Not sure if this is still needed. Looks like the reverse was removed from master. |
|
See b4ae232. Although tests weren't added there. |
|
Removed the fix but kept the test. Will see if it passes haha. |
|
Hum. Looks like travis isn't set up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong used .reverse() in availableForType
beware:
.reverse()does modify the original array! This can be prevented by creating a new array with[...arr].Fixes #432