Sketch feature #45
Sketch feature #45
Conversation
|
Plugin with feature toggled off Plugin with feature toggled on |
src/resources/META-INF/plugin.xml
Outdated
| @@ -53,6 +53,9 @@ | |||
| class="org.jetbrains.plugins.d2.action.D2LayoutEngineActionGroup" | |||
| popup="true" | |||
| icon="AllIcons.General.Layout"/> | |||
| <action id="D2.SketchMode" | |||
| class="org.jetbrains.plugins.d2.action.D2SketchToggleAction" | |||
| icon="AllIcons.Actions.EnableNewUi"/> | |||
There was a problem hiding this comment.
Let's use another icon here. Something to highlight is that the style looks hand-drawn. A random option:
There was a problem hiding this comment.
Could you please provide this icon ID? I'm not sure I've seen it within the available IntelliJ options
There was a problem hiding this comment.
Sorry, I can't provide you with a specific id. Please, take a look at the existing icons here: https://jetbrains.design/intellij/resources/icons_list/
If there are no suitable icons, consider adding one following the documentation here: https://plugins.jetbrains.com/docs/intellij/icons.html
There was a problem hiding this comment.
What do yo think about the options above? It's the best I could find with "hand-drawn", "hand-made", "hand", "pen", "pencil", "painting", "draw", "drawing", "sketch" keywords similar to your proposal.
Your suggested icon doesn't seem to fit right (had to resize it and cannot change color black) and it's licensed (not sure whether you want and how to properly give credits to the creator)
Personally, I don't like the second option and I'd go with the first one. Let me know
There was a problem hiding this comment.
Thank you for your research on that! For me, the pencil in the first icon looks like the best option here :)
There was a problem hiding this comment.
Uploaded the first one for now
There was a problem hiding this comment.
Sorry, which one then?
Option 1 (already uploaded):
Option 2:
Option 3 (yours, has license):
There was a problem hiding this comment.
Option 1 looks best for me
There was a problem hiding this comment.
Great. All set then. Thanks for your feedback!
| @@ -21,6 +21,9 @@ group.D2.ThemeChooser.description=Choose a theme for D2 diagram | |||
| group.D2.LayoutChooser.text=Layout Chooser | |||
| group.D2.LayoutChooser.description=Choose a layout for D2 diagram | |||
|
|
|||
| action.D2.SketchMode.text=Sketch | |||
There was a problem hiding this comment.
Should it be Sketch Mode instead?
src/src/editor/D2CompilerState.kt
Outdated
| @@ -13,6 +13,7 @@ internal class D2CompilerState( | |||
| val port: Int, | |||
| val theme: String?, | |||
| val layout: D2Layout?, | |||
| val sketch: Boolean?, | |||
There was a problem hiding this comment.
Can we switch to a nonnull type Boolean here?
There was a problem hiding this comment.
I'll give it a try. This is my first time with Kotlin 😄
src/src/editor/D2Viewer.kt
Outdated
| internal data class D2FileEditorState(@JvmField var theme: D2Theme?, @JvmField val layout: D2Layout?) : FileEditorState { | ||
| internal data class D2FileEditorState(@JvmField var theme: D2Theme?, | ||
| @JvmField val layout: D2Layout?, | ||
| @JvmField val sketch: Boolean?) : FileEditorState { |
There was a problem hiding this comment.
We could specify a default value here with @Default(false) and make the field not nullable
There was a problem hiding this comment.
Couldn't find a suitable @default annotation, set the default with "= false"
There was a problem hiding this comment.
I'm not familiar with kotlinx.serialization enough. Sorry for a misleading suggestion :)
The default value looks like the right solution according to the docs.
- Changed Sketch Mode text - Made sketch Boolean non-nullable - Changed Sketch Mode icon (pending review)
Hey! I liked your plugin and really wanted to use the sketch mode, but since D2 parameters are not open to edit through an input field (this might be a nice option that allow people to play with D2 without major efforts) I forked your project and made this little enhancement. Hope it can be included in the original plugin!