-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes anchor tags for NPM #1071
Conversation
`<a src="#*">` are not supported on NPM, it might be better to just use the automatically generated anchor IDs since this means the table of contents will work on both Github and NPM
|
<a href="#modern">Modern Mode</a> ✯ | ||
<a href="#usage">Usage & Configuration</a> ✯ | ||
<a href="#options">All Options</a> | ||
<a href="#-installation--setup--">Setup</a> ✯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to work on GitHub though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me spin up a local version of the repo and preview the markdown in VS Code and see whether that changes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub's markdown renderer is notoriously inconsistent cross-platform, but this doesn't work for me on Windows Chrome & FF, Linux FF, or iOS Safari.
Test on the readme of your fork, does this link actually work? https://github.com/schalkventer/microbundle/tree/patch-1#-installation--setup--
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a single environment in which those trailing -
's are present -- what's your system details? Where are you running this where that gets generated?
<a src="#*">
are not supported on NPM, it might be better to just use the automatically generated anchor IDs since this means the table of contents will work on both Github and NPMFor example
https://www.npmjs.com/package/microbundle#formats
does not work, buthttps://www.npmjs.com/package/microbundle#-output-formats-
works.