use-test-tables for testing flags #2041
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| testBuildBuildArgNoKey, | ||
| testBuildLabelNoKey, | ||
| testBuildCacheExportNotSupported, | ||
| testBuildOCIExportNotSupported, | ||
| testBuildMultiPlatformNotSupported, |
There was a problem hiding this comment.
If we want test tables I think we should group testBuildBuildArgNoKey, testBuildLabelNoKey and name it testBuildKeyPairNoKey and for testBuildCacheExportNotSupported, testBuildOCIExportNotSupported, testBuildMultiPlatformNotSupported have another one named testBuildDockerNotSupported.
There was a problem hiding this comment.
Ah missed your comment #1998 (comment). So I think we should split them because they don't have the same input and purpose.
There was a problem hiding this comment.
@thaJeztah Needs a rebase.
There is a difference between these variants. Before tests run in isolated environments while in the new one they share same state. Unlikely that for this specific case this would actually cause a behavior difference but we should not go too far with this pattern.
No description provided.