Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: handle multiple docker versions #2307

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 5, 2024

crazy-max and others added 3 commits March 7, 2024 19:32
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

@tonistiigi As discussed we could also handle builders through docker context with specific dind image as follow-up.

@crazy-max crazy-max marked this pull request as ready for review March 7, 2024 18:35
@davhdavh
Copy link

davhdavh commented Mar 8, 2024

These seem relevant to this pr:

buildx/tests/build.go

Lines 442 to 443 in 4327ee7

// TODO: use stable buildkit image when v0.13.0 released
out, err := createCmd(sb, withArgs("--driver", "docker-container", "--buildkitd-flags=--oci-worker-net=bridge --allow-insecure-entitlement=network.host", "--driver-opt", "image=moby/buildkit:v0.13.0-rc3"))

buildx/tests/build.go

Lines 576 to 577 in 4327ee7

// TODO: use stable buildkit image when v0.13.0 released
out, err := createCmd(sb, withArgs(

buildx/tests/build.go

Lines 643 to 644 in 4327ee7

// TODO: use stable buildkit image when v0.13.0 released
out, err := createCmd(sb, withArgs(

@crazy-max
Copy link
Member Author

These seem relevant to this pr:

buildx/tests/build.go

Lines 442 to 443 in 4327ee7

// TODO: use stable buildkit image when v0.13.0 released
out, err := createCmd(sb, withArgs("--driver", "docker-container", "--buildkitd-flags=--oci-worker-net=bridge --allow-insecure-entitlement=network.host", "--driver-opt", "image=moby/buildkit:v0.13.0-rc3"))

buildx/tests/build.go

Lines 576 to 577 in 4327ee7

// TODO: use stable buildkit image when v0.13.0 released
out, err := createCmd(sb, withArgs(

buildx/tests/build.go

Lines 643 to 644 in 4327ee7

// TODO: use stable buildkit image when v0.13.0 released
out, err := createCmd(sb, withArgs(

WDYM? This PR is about testing multiple dockerd versions. For BuildKit see #2322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants