Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump compose-go to v2.1.1 #2425

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Apr 23, 2024

Use the latest version v2.1.0 of compose-go with bake.
This one introduces entitlements attribute which is managed on the Compose side

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours requested review from crazy-max and a team April 23, 2024 08:59
@tonistiigi
Copy link
Member

This one introduces entitlements attribute which is managed on the Compose side

I don't think this actually works with bake as I don't see the values passed through, or am I missing something?

Also, not sure if we should enable this (without some explicit insecure-mode opt-in) before #179

@crazy-max
Copy link
Member

@glours Looks like 2.1.1 is out, can you bump to this version instead? Thanks.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title bumpo compose-go to v2.1.0 bump compose-go to v2.1.1 May 30, 2024
@glours
Copy link
Contributor Author

glours commented May 30, 2024

Hahah @crazy-max I just see your message, is it too late to bump the version?

@glours
Copy link
Contributor Author

glours commented May 30, 2024

Ok I just see that you already added a commit to bump the version 🤦‍♂️

@crazy-max
Copy link
Member

Hahah @crazy-max I just see your message, is it too late to bump the version?

No worries I bumped it myself, see last commit.

@thompson-shaun thompson-shaun merged commit 1f28985 into docker:master May 30, 2024
102 checks passed
@thompson-shaun thompson-shaun added dependencies Pull requests that update a dependency file kind/chore Routine project support tasks labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kind/chore Routine project support tasks status/code-review status/needs-follow-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants