vendor: update buildx to latest docker/cli #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
commented
May 16, 2024
| @@ -269,8 +269,7 @@ func (o *buildOptionsHash) String() string { | |||
| } | |||
|
|
|||
| func runBuild(ctx context.Context, dockerCli command.Cli, options buildOptions) (err error) { | |||
| mp := dockerCli.MeterProvider(ctx) | |||
| defer metricutil.Shutdown(ctx, mp) | |||
| mp := dockerCli.MeterProvider() | |||
There was a problem hiding this comment.
This returns a meter provider initialized by the CLI now and the CLI handles reporting and shutdown now.
Need to double check that this works correctly with standalone.
crazy-max
reviewed
May 16, 2024
This version of docker/cli has changes to remove compose-cli wrapper and move all CLI metrics to OTEL. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
|
cc @laurazard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of docker/cli has changes to remove compose-cli wrapper and move all CLI metrics to OTEL.