Add test case to document env header contains whitespace error as expected behavior. #5081
+5,799
−18,611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benehiko
reviewed
Jun 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5081 +/- ##
=======================================
Coverage 61.33% 61.33%
=======================================
Files 298 298
Lines 20692 20691 -1
=======================================
Hits 12691 12691
+ Misses 7100 7099 -1
Partials 901 901 |
|
Thanks @Benehiko, I merged back up with master, it seems my editor was trying to change formatting on container_run.md, but I think I got it fixed. Let me know any feedback! Thank you! |
Signed-off-by: njucjc <njucjc@gmail.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: racequite <quiterace@gmail.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: cncal <flycalvin@qq.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Co-authored-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Co-authored-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
full diff: moby/moby@v26.1.0...06e3a49 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signatures of these functions were changed in 80d92fd45007b6395dc2db5f93def3b159dacd7f Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Don't show `Next steps:` with no messages at all when plugin returns an unitialized value of `HookMessage` (zero-initialization sets its type to NextSteps and empty template). Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Cross compiling CGO to Darwin requires an Apple SDK. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
So we can also have darwin binaries in the `dockereng/cli-bin` image. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
The "--rm" flag deletes both the container and any anonymous volumes associated with the container when the container exits. This patch updates the flag description to also mention volumes. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
This may need further discussion, but we currently handle dangling symlinks gracefully, so let's add a test for this, and verify that we don't replace symlinks with a file. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
…nted Loading the config should print no warnings on a successful load. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
When attempting to load a config-file that exists, but is not accessible for the current user, we should not discard the error. This patch makes sure that the error is returned by Load(), but does not yet change LoadDefaultConfigFile, as this requires a change in signature. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
The output showed the Alpine version that was used for the example, which can get outdated and distracts from the example steps. Use --quiet to reduce the output, and to reduce maintenance (i.e., no need to keep the output updated with current versions). Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
no changes to vendored code full diff: docker/docker-credential-helpers@v0.8.1...v0.8.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
- 0.14.1 release notes: https://github.com/docker/buildx/releases/tag/v0.14.1 - 0.14.0 release notes: https://github.com/docker/buildx/releases/tag/v0.14.0 - 0.13.1 release notes: https://github.com/docker/buildx/releases/tag/v0.13.1 - 0.13.0 release notes: https://github.com/docker/buildx/releases/tag/v0.13.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
release notes: https://github.com/docker/compose/releases/tag/v2.27.1 full diff: docker/compose@v2.24.3...v2.27.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
The github.com/containerd/containerd/platforms package was moved to a separate module in preparation of the containerd v2.0 release. Switch to the new module, which means we also remove containerd as a direct dependency. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Update to the current version of Alpine, which is also the default for the golang:alpine image Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Nick Sieger <nick@nicksieger.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
full diff: distribution/reference@v0.5.0...v0.6.0 - remove deprecated SplitHostname - refactor splitDockerDomain to include more documentation - fix typo in readme - Exclude domain from name length check Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Rename some variables to prevent shadowing and for clarity. Also made some minor formatting changes. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
full diff: moby/moby@59996a4...a736d07 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Rename variable that shadowed an import, and pass the network API-client instead of the whole CLI Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
internal/test/cli.go:175:14: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("no notary client available unless defined")
^
cli/command/cli.go:318:29: fmt.Errorf can be replaced with errors.New (perfsprint)
return docker.Endpoint{}, fmt.Errorf("no context store initialized")
^
cli/command/container/attach.go:161:11: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf(result.Error.Message)
^
cli/command/container/opts.go:577:16: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("--health-start-period cannot be negative")
^
cli/command/container/opts.go:580:16: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("--health-start-interval cannot be negative")
^
cli/command/container/stats.go:221:11: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("filtering is not supported when specifying a list of containers")
^
cli/command/container/attach_test.go:82:17: fmt.Errorf can be replaced with errors.New (perfsprint)
expectedErr = fmt.Errorf("unexpected error")
^
cli/command/container/create_test.go:234:40: fmt.Errorf can be replaced with errors.New (perfsprint)
return container.CreateResponse{}, fmt.Errorf("shouldn't try to pull image")
^
cli/command/container/list_test.go:150:17: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("error listing containers")
^
cli/command/container/rm_test.go:40:31: fmt.Errorf can be replaced with errors.New (perfsprint)
return errdefs.NotFound(fmt.Errorf("Error: no such container: " + container))
^
cli/command/container/run_test.go:138:40: fmt.Errorf can be replaced with errors.New (perfsprint)
return container.CreateResponse{}, fmt.Errorf("shouldn't try to pull image")
^
cli/command/image/pull_test.go:115:49: fmt.Errorf can be replaced with errors.New (perfsprint)
return io.NopCloser(strings.NewReader("")), fmt.Errorf("shouldn't try to pull image")
^
cli/command/network/connect.go:88:16: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("invalid key/value pair format in driver options")
^
cli/command/plugin/create_test.go:96:11: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("Error creating plugin")
^
cli/command/plugin/disable_test.go:32:12: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("Error disabling plugin")
^
cli/command/plugin/enable_test.go:32:12: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("failed to enable plugin")
^
cli/command/plugin/inspect_test.go:55:22: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, nil, fmt.Errorf("error inspecting plugin")
^
cli/command/plugin/install_test.go:43:17: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("Error installing plugin")
^
cli/command/plugin/install_test.go:51:17: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("(image) when fetching")
^
cli/command/plugin/install_test.go:95:17: fmt.Errorf can be replaced with errors.New (perfsprint)
return nil, fmt.Errorf("should not try to install plugin")
^
cli/command/plugin/list_test.go:35:41: fmt.Errorf can be replaced with errors.New (perfsprint)
return types.PluginsListResponse{}, fmt.Errorf("error listing plugins")
^
cli/command/plugin/remove_test.go:27:12: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("Error removing plugin")
^
cli/command/registry/login_test.go:36:46: fmt.Errorf can be replaced with errors.New (perfsprint)
return registrytypes.AuthenticateOKBody{}, fmt.Errorf("Invalid Username or Password")
^
cli/command/registry/login_test.go:44:46: fmt.Errorf can be replaced with errors.New (perfsprint)
return registrytypes.AuthenticateOKBody{}, fmt.Errorf(errUnknownUser)
^
cli/command/system/info.go:190:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("errors pretty printing info")
^
cli/command/system/prune.go:77:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf(`ERROR: The "until" filter is not supported with "--volumes"`)
^
cli/command/system/version_test.go:19:28: fmt.Errorf can be replaced with errors.New (perfsprint)
return types.Version{}, fmt.Errorf("no server")
^
cli/command/trust/key_load.go:112:22: fmt.Errorf can be replaced with errors.New (perfsprint)
return []byte{}, fmt.Errorf("could not decrypt key")
^
cli/command/trust/revoke.go:44:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("cannot use a digest reference for IMAGE:TAG")
^
cli/command/trust/revoke.go:105:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("no signed tags to remove")
^
cli/command/trust/signer_add.go:56:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("releases is a reserved keyword, please use a different signer name")
^
cli/command/trust/signer_add.go:60:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("path to a public key must be provided using the `--key` flag")
^
opts/config.go:71:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("source is required")
^
opts/mount.go:168:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("type is required")
^
opts/mount.go:172:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("target is required")
^
opts/network.go:90:11: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("network name/id is not specified")
^
opts/network.go:129:18: fmt.Errorf can be replaced with errors.New (perfsprint)
return "", "", fmt.Errorf("invalid key value pair format in driver options")
^
opts/opts.go:404:13: fmt.Errorf can be replaced with errors.New (perfsprint)
return 0, fmt.Errorf("value is too precise")
^
opts/opts.go:412:18: fmt.Errorf can be replaced with errors.New (perfsprint)
return "", "", fmt.Errorf("empty string specified for links")
^
opts/parse.go:84:37: fmt.Errorf can be replaced with errors.New (perfsprint)
return container.RestartPolicy{}, fmt.Errorf("invalid restart policy format: no policy provided before colon")
^
opts/parse.go:89:38: fmt.Errorf can be replaced with errors.New (perfsprint)
return container.RestartPolicy{}, fmt.Errorf("invalid restart policy format: maximum retry count must be an integer")
^
opts/port.go:105:13: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("hostip is not supported")
^
opts/secret.go:70:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("source is required")
^
opts/env_test.go:57:11: fmt.Errorf can be replaced with errors.New (perfsprint)
err: fmt.Errorf("invalid environment variable: =a"),
^
opts/env_test.go:93:11: fmt.Errorf can be replaced with errors.New (perfsprint)
err: fmt.Errorf("invalid environment variable: ="),
^
cli-plugins/manager/error_test.go:16:11: fmt.Errorf can be replaced with errors.New (perfsprint)
inner := fmt.Errorf("testing")
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
…print)
cli/registry/client/endpoint.go:128:34: fmt.Sprintf can be replaced with string concatenation (perfsprint)
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", th.token))
^
cli/command/telemetry_docker.go:88:14: fmt.Sprintf can be replaced with string concatenation (perfsprint)
endpoint = fmt.Sprintf("unix://%s", path.Join(u.Host, u.Path))
^
cli/command/cli_test.go:195:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
opts := &flags.ClientOptions{Hosts: []string{fmt.Sprintf("unix://%s", socket)}}
^
cli/command/registry_test.go:59:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
inputServerAddress: fmt.Sprintf("https://%s", testAuthConfigs[1].ServerAddress),
^
cli/command/container/opts_test.go:338:35: fmt.Sprintf can be replaced with string concatenation (perfsprint)
if config, _, _ := mustParse(t, fmt.Sprintf("--hostname=%s", hostname)); config.Hostname != expectedHostname {
^
cli/command/context/options.go:79:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
errs = append(errs, fmt.Sprintf("%s: unrecognized config key", k))
^
cli/command/image/build.go:461:68: fmt.Sprintf can be replaced with string concatenation (perfsprint)
line = dockerfileFromLinePattern.ReplaceAllLiteralString(line, fmt.Sprintf("FROM %s", reference.FamiliarString(trustedRef)))
^
cli/command/image/remove_test.go:21:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("Error: No such image: %s", n.imageID)
^
cli/command/image/build/context.go:229:102: fmt.Sprintf can be replaced with string concatenation (perfsprint)
progReader := progress.NewProgressReader(response.Body, progressOutput, response.ContentLength, "", fmt.Sprintf("Downloading build context from remote url: %s", remoteURL))
^
cli/command/service/logs.go:215:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
taskName += fmt.Sprintf(".%s", task.ID)
^
cli/command/service/logs.go:217:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
taskName += fmt.Sprintf(".%s", stringid.TruncateID(task.ID))
^
cli/command/service/progress/progress_test.go:877:18: fmt.Sprintf can be replaced with string concatenation (perfsprint)
ID: fmt.Sprintf("task%s", nodeID),
^
cli/command/stack/swarm/remove.go:61:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
errs = append(errs, fmt.Sprintf("Failed to remove some resources from stack: %s", namespace))
^
cli/command/swarm/ipnet_slice_test.go:32:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
arg := fmt.Sprintf("--cidrs=%s", strings.Join(vals, ","))
^
cli/command/swarm/ipnet_slice_test.go:137:30: fmt.Sprintf can be replaced with string concatenation (perfsprint)
if err := f.Parse([]string{fmt.Sprintf("--cidrs=%s", strings.Join(test.FlagArg, ","))}); err != nil {
^
cli/compose/schema/schema.go:105:11: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("must be a %s", humanReadableType(expectedType))
^
cli/manifest/store/store.go:165:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("No such manifest: %s", n.object)
^
e2e/image/push_test.go:340:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_ROOT_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:341:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_TARGETS_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:342:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_SNAPSHOT_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:343:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_DELEGATION_PASSPHRASE=%s", pwd),
^
e2e/plugin/trust_test.go:23:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
pluginName := fmt.Sprintf("%s/plugin-content-trust", registryPrefix)
^
e2e/plugin/trust_test.go:53:8: fmt.Sprintf can be replaced with string concatenation (perfsprint)
Out: fmt.Sprintf("Installed plugin %s", pluginName),
^
e2e/trust/revoke_test.go:62:57: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.RunCommand("docker", "tag", fixtures.AlpineImage, fmt.Sprintf("%s:v1", revokeRepo)).Assert(t, icmd.Success)
^
e2e/trust/revoke_test.go:64:49: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.Command("docker", "-D", "trust", "sign", fmt.Sprintf("%s:v1", revokeRepo)),
^
e2e/trust/revoke_test.go:68:58: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.RunCommand("docker", "tag", fixtures.BusyboxImage, fmt.Sprintf("%s:v2", revokeRepo)).Assert(t, icmd.Success)
^
e2e/trust/revoke_test.go:70:49: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.Command("docker", "-D", "trust", "sign", fmt.Sprintf("%s:v2", revokeRepo)),
^
e2e/trust/sign_test.go:36:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.AlpineSha)))
^
e2e/trust/sign_test.go:53:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.BusyboxSha)))
^
e2e/trust/sign_test.go:65:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.AlpineSha)))
^
opts/file.go:21:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("poorly formatted environment: %s", e.msg)
^
opts/hosts_test.go:26:31: fmt.Sprintf can be replaced with string concatenation (perfsprint)
"tcp://host:": fmt.Sprintf("tcp://host:%s", defaultHTTPPort),
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Looks like it's broken, so use a blanket "nolint:gosec" instead;
cli/command/image/build/context.go:238:17: G107: Potential HTTP request made with variable url (gosec)
if resp, err = http.Get(url); err != nil {
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
full diff: golangci/golangci-lint@v1.55.2...v1.59.0 Updated config to address warnings: WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`. WARN [config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
full diff: moby/moby@a736d07...9d94884 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Print note when the multi-platform image was reduced to a single manifest. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Grace Choi <gracechoi@utexas.edu> Signed-off-by: Pranjal Rai <pranjalrai@utexas.edu> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Marius Meschter <marius@meschter.me> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
This wraps the cli stderr stream the same way as stdin and stdout, which extends the stream with TTY-related methods. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
|
My bad, when I followed the DCO after the merge by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
[config 1]will throw an error is expected behavior.docker runthrows error if an env var contains whitespace #5057- How to verify it
docker buildx bake testlooked good to me- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
