Add test case to document env header contains whitespace error as expected behavior. #5081
+40
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: njucjc <njucjc@gmail.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: racequite <quiterace@gmail.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Signed-off-by: cncal <flycalvin@qq.com> Signed-off-by: MicahKimel <micah.kimel@my.wheaton.edu>
Benehiko
reviewed
Jun 11, 2024
Comment on lines
+100
to
+102
| if err == nil { | ||
| t.Fatalf("Expected an ErrBadKey, got nothing") | ||
| } |
There was a problem hiding this comment.
Suggested change
| if err == nil { | |
| t.Fatalf("Expected an ErrBadKey, got nothing") | |
| } | |
| assert.ErrorIs(t, err, ErrBadKey{"variable '[config 1]' contains whitespaces"}) |
There was a problem hiding this comment.
with this assertion we don't need the other checks below
| - A valid CDI specification (JSON or YAML file) for the requested device is | ||
| available on the system running the daemon, in one of the configured CDI | ||
| specification directories. | ||
| - The CDI feature has been enabled in the daemon; see [Enable CDI |
There was a problem hiding this comment.
Suggested change
| - The CDI feature has been enabled in the daemon; see [Enable CDI | |
| - The CDI feature has been enabled in the daemon. See [Enable CDI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5081 +/- ##
=======================================
Coverage 61.33% 61.33%
=======================================
Files 298 298
Lines 20692 20691 -1
=======================================
Hits 12691 12691
+ Misses 7100 7099 -1
Partials 901 901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
[config 1]will throw an error is expected behavior.docker runthrows error if an env var contains whitespace #5057- How to verify it
docker buildx bake testlooked good to me- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
