Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing individual json objects into json array #5052

Closed
wants to merge 1 commit into from

Conversation

arankeparth
Copy link

- What I did
Added commas between individual json objects and then added brackets around them to make an array.

- How I did it
Read each line from the buffer then added comma and finally added brackets.

- How to verify it

- Description for the changelog
Parsing individual json objects into json array

@arankeparth
Copy link
Author

arankeparth commented May 2, 2024

This is a slightly dirty fix. please suggest some changes if possible!

Signed-off-by: parth aranke <arankeparth1912@gmail.com>
@thaJeztah
Copy link
Member

This would be a breaking change; the current output is line-delimited JSON, which most tools would be able to handle already.

@neersighted
Copy link
Member

I'm going to close this for now; not only is this an undesired breaking change (the output here has always intentionally been JSON lines), but kludging an array together using string manipulation (instead of changing the serialization code) is not a sensible way to make this change even if it was desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants