update RunWithStatus(...) to respect custom writer attached by WithContextWriter(...)
#10097
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigerinus
force-pushed
the
writer_fix
branch
3 times, most recently
from
34a5480
to
b34c0a7
Compare
ndeloof
approved these changes
Dec 19, 2022
|
@ndeloof can u help me to understand about the failing e2e tests? |
|
@ndeloof - can you approve this one more time? I saw the other PR passed the e2e tests, so I wonder if the failed e2e tests here are due to the changes I made. Thanks! |
|
@ndeloof - I ran the e2e tests again, with and without my PR changes, both ran into the 15min timeout. Could it be irrelevant but intermittent issue? Does it have to block the PR merge? Thanks! |
…ntextWriter(...) Signed-off-by: Tiger Wang <tigerwang@outlook.com>
Signed-off-by: Tiger Wang <tigerwang@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
RunWithStatus(...)to respect custom writer if it is attached to thectxpassed in.progress.WithContextWriter(ctx, writer)from external is not respeced #10091Related issue
progress.WithContextWriter(ctx, writer)from external is not respeced #10091