generate provenance attestation #11797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
glours,
milas and
jhrotko
and removed request for
a team
ndeloof
force-pushed
the
main
branch
3 times, most recently
from
ad8dbd5
to
18358ee
Compare
milas
reviewed
May 7, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
255
to
256
| id-token: write | ||
| attestations: write |
There was a problem hiding this comment.
I think the binary job needs these permissions to fix the CI error?
The GitHub docs are a bit vague but say (emphasis mine):
In the workflow that builds the binary you would like to attest, add the following permissions.
There was a problem hiding this comment.
it seems this does not work on forks? actions/deploy-pages#184 (comment)
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
ok giving up with this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
produce provenance attestations for artifacts being built during release
see https://docs.github.com/en/actions/security-guides/using-artifact-attestations-to-establish-provenance-for-builds