Dockerfile: merge build stages #249
Open
+20
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
thaJeztah
reviewed
Nov 9, 2022
| make build-osxkeychain build-pass PACKAGE=$PACKAGE VERSION=$(cat /tmp/.version) REVISION=$(cat /tmp/.revision) DESTDIR=/out | ||
| xx-verify /out/docker-credential-osxkeychain | ||
| xx-verify /out/docker-credential-pass | ||
| case "$(xx-info os)" in |
There was a problem hiding this comment.
Isn't this the same as TARGETOS ?
There was a problem hiding this comment.
We use xx-info os because we don't expose ARG TARGETOS but ARG TARGETPLATFORM which already contains the os and xx is able to parse: https://github.com/tonistiigi/xx/blob/aba3b88003b046b8557cdf25959ba0c3c81394c2/base/xx-info#L82
It's just to avoid adding the extra TARGETOS arg if that makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't need extra stages per target os.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com