-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add language specific guide for c++ #19903
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @Pradumnasaraf,
|
Hey, @craig-osterhout. Thank you for the feedback. I have updated the docs as you requested. |
Hey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @Pradumnasaraf for your contribution. I left some review comments.
Also, feel free to add an acknowledgement callout for yourself like https://github.com/docker/docs/blob/main/content/language/golang/_index.md?plain=1#L11
Clone the sample application to use with this guide. Open a terminal, change directory to a directory that you want to work in, and run the following command to clone the repository: | ||
|
||
```console | ||
$ git clone https://github.com/Pradumnasaraf/c-plus-plus-docker.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fork your repo to a Docker-controlled repo and update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, go ahead, Craig.
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
Co-authored-by: Craig Osterhout <103533812+craig-osterhout@users.noreply.github.com>
Hey @craig-osterhout, thanks for the review. I have addressed all of them. |
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Hello. I just pushed a small change to use a different, shorter subpath for this guide: from |
Description
Related issues or tickets
fix #19898
Reviews