docker auth: improve missing user/pwd

[Frankkkkk]

Specify the "missing username and password" error message. This makes debugging the action easier when for example mistyping the username or the password.

Thanks and cheers!

[crazy-max]

Thanks for this PR but I think the error message to users should remain generic. You can still check what value is empty in the login step (expand Run docker/login-action@v3):

[Frankkkkk]

Hi @crazy-max , thanks for your message.
Any reason why you want the error message to be generic? I genuinely can't see why?

These actions are also used outside Github (for example on Gitea or Forgejo. Basically on any act runner). On those, the details are not shown:

Thus why it adds more info
Thanks

[crazy-max]

Ok this change sounds good considering how other providers currently consume GitHub Actions.

You forgot to run docker buildx bake pre-checkin to update generated content btw, see https://github.com/docker/login-action/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request. Take this commit as example: https://github.com/docker/login-action/pull/677/commits

Don't forget to squash commits as well. Thanks.

[Frankkkkk]

Done, thanks.
Curious question: the dist file are so large; how do you make sure that a malicious user didn't embed some nefarious content in it ?
Subsidiary one: how do you deal with conflicts on MRs ? Do all contributors always have to rebase on every change on main?
Thanks!

[crazy-max]

Curious question: the dist file are so large; how do you make sure that a malicious user didn't embed some nefarious content in it ?

We have a scanner and CodeQL running as well to avoid that. Also considering our dependencies tree we are quite confident we consume vetted packages:

login-action/package.json

Lines 27 to 34 in 70fccc7

	"dependencies": {
	"@actions/core": "^1.10.1",
	"@aws-sdk/client-ecr": "^3.529.1",
	"@aws-sdk/client-ecr-public": "^3.529.1",
	"@docker/actions-toolkit": "^0.23.0",
	"http-proxy-agent": "^7.0.2",
	"https-proxy-agent": "^7.0.4"
	},

Subsidiary one: how do you deal with conflicts on MRs ? Do all contributors always have to rebase on every change on main?

Yes indeed this is currently painful but no other choice atm. GitHub plans to change that in the future to use GitHub Packages to ship actions instead (was told about this two years ago though).

[crazy-max]

LGTM thanks!