Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use path.join for toc source #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knownasilya
Copy link
Member

@knownasilya knownasilya commented Nov 1, 2016

WIP

Possible fix for docpress/docpress#169
Not sure about the replace line after, what would it be in windows? Would love to have some example paths for windows.

TODO

  • Test on windows before merge.

@coveralls
Copy link

coveralls commented Nov 1, 2016

Coverage Status

Coverage remained the same at 97.126% when pulling 1f9d6a0 on handle-toc-windows into 75f6c99 on master.

@Kikobeats Kikobeats changed the title Use path.join for toc source [WIP] Use path.join for toc source Nov 3, 2016
@Kikobeats
Copy link
Contributor

@knownasilya what do you want to determinate if could be or not be merged?

@knownasilya
Copy link
Member Author

This needs to be tested on windows before merge.

@cvax
Copy link

cvax commented Nov 21, 2016

This is what I am getting on Windows 7 with this commit and the same repo for docpress/docpress#169.

 docpress serve

  Docpress
  starting development - ^C to exit

   err ✗    first build
    ✓ on    livereload
    ✓ on    http://localhost:3000

            Running

  ✗ docs\README.md: Unknown reference '../README.md'
    at fix (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\docpress-core\lib\fix_html.js:64:13)
    at Object.<anonymous> (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\docpress-core\lib\fix_html.js:41:29)

    at initialize.exports.each (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\cheerio\lib\api\traversing.js:300:24)
    at fixReferences (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\docpress-core\lib\fix_html.js:39:22)
    at fixHtml (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\docpress-core\lib\fix_html.js:15:3)
    at m (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\docpress-core\lib\index.js:241:7)
    at memoize (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\docpress-core\lib\memoize.js:19:15)
    at each (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\docpress-core\lib\index.js:239:15)
    at C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\lodash\_createBaseFor.js:17:11
    at baseForOwn (C:\Users\cvax\AppData\Roaming\nvm\v6.9.1\node_modules\docpress\node_modules\lodash\_baseForOwn.js:13:20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants