Prevent measure in flexlayout during arrange pass #22411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foda
added
platform/windows 🪟
area-layout
|
Are these two comments:
possibly relevant here? |
Yup! This PR also fixes that issue |
|
/rebase |
github-actions
bot
force-pushed
the
foda/FlexLayoutCrash
branch
from
4e97369
to
bc36d3a
Compare
PureWeen
previously approved these changes
May 16, 2024
added 2 commits
May 17, 2024 11:14
…into foda/FlexLayoutCrash
PureWeen
previously approved these changes
May 17, 2024
PureWeen
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Prevent measure in flexlayout during arrange pass, which fixes a layout cycle crash on Windows. No automated test for this one as I haven't quite figured out how to replicate a 125% display res change on CI
Issues Fixed
Fixes #22209 #9075