Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Selected Icon Color not changing if using Font icons - fix #22437

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented May 15, 2024

Issues Fixed

Fixes #22032
Fixes #12250
Fixes #20866

Before After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-16.at.00.46.53.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-16.at.00.40.40.mp4

@kubaflo kubaflo requested a review from a team as a code owner May 15, 2024 22:47
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 15, 2024
@@ -38,7 +38,7 @@ public static partial class ImageSourceExtensions
var image = UIGraphics.GetImageFromCurrentImageContext();
UIGraphics.EndImageContext();

return image.ImageWithRenderingMode(UIImageRenderingMode.AlwaysOriginal);
return image.ImageWithRenderingMode(UIImageRenderingMode.Automatic);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattleibow thoughts?

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot May 20, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-tabbedpage TabbedPage community ✨ Community Contribution
Projects
None yet
3 participants