[Android] Fix flyout behaviour switching exception #22453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
What to do with these failing tests? |
|
@imuller can you add UITests to this? Here's an example |
|
@PureWeen Can you check the added tests |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
May 21, 2024
| public override string Issue => "FlyoutPage Android app crashing on orientation change when flyout is open"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.FlyoutPage)]] |
There was a problem hiding this comment.
Can you remove the last ] from this line?
D:\a\_work\1\s\src\Controls\tests\TestCases.Shared.Tests\Tests\Issues\Issue20858.cs(16,41): error CS1519: Invalid token ']' in class, record, struct, or interface member declaration [D:\a\_work\1\s\src\Controls\tests\TestCases.iOS.Tests\Controls.TestCases.iOS.Tests.csproj]
393 Warning(s)
8 Error(s)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jsuarezruiz Any idea why these tests are failing? |
|
Any update on this please? |
|
? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Two issues where fixed in this PR:
Issues Fixed
#20858
#18161